Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fragment shorthand not compatible with jsx-factory #480

Closed
AlexReff opened this issue Nov 13, 2019 · 4 comments
Closed

Fragment shorthand not compatible with jsx-factory #480

AlexReff opened this issue Nov 13, 2019 · 4 comments

Comments

@AlexReff
Copy link

See: microsoft/TypeScript#20469

JSX fragment is not supported when using --jsxFactory ts(17016)

Documentation should be updated to clarify how to use <></> Fragment shorthand syntax. I could not get it working correctly.
@marvinhagemeister
Copy link
Member

That issue is specific to TypeScript. We don't have a page dedicated to TS yet. If we do it makes sense to put it there 👍

@marvinhagemeister marvinhagemeister transferred this issue from preactjs/preact Nov 14, 2019
@AlexReff
Copy link
Author

Would you accept a pull request with a note for Typescript users, or are you planning on having entirely separate documentation for Typescript?

@marvinhagemeister
Copy link
Member

A note is perfectly fine for now. It's better than what we have right now 👍 Happy to review any PRs 🎉 💯

A dedicated TS page may be something for later.

@rschristian
Copy link
Member

At some point a dedicated TS page was added with info on how to set the jsxFragmentFactory, so I'll close this on out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marvinhagemeister @AlexReff @rschristian