Skip to content

Commit

Permalink
remove side-effects in unit tests and update test ad domain
Browse files Browse the repository at this point in the history
  • Loading branch information
Fang Bai committed Nov 8, 2017
1 parent 68e299e commit 630b68e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion modules/openxBidAdapter.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Module that connects to OpenX's demand sources
bidder: 'openx',
params: {
unit: '539131525',
delDomain: 'se-demo-d.openx.net',
delDomain: 'zdo.com',
video: {
url: 'abc.com'
}
Expand Down
4 changes: 2 additions & 2 deletions test/spec/modules/openxBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ describe.only('OpenxAdapter', () => {
});

it('handles nobid responses', () => {
bidResponse = {
let bidResponse = {
'ads':
{
'version': 1,
Expand Down Expand Up @@ -352,7 +352,7 @@ describe.only('OpenxAdapter', () => {
});

it('handles nobid responses', () => {
bidResponse = {'cache_key': '', 'pub_rev': '', 'per_colo_domain': '', 'ph': ''};
let bidResponse = {'cache_key': '', 'pub_rev': '', 'per_colo_domain': '', 'ph': ''};
let result = spec.interpretResponse({body: bidResponse}, bidRequest);
expect(result.length).to.equal(0);
});
Expand Down

0 comments on commit 630b68e

Please sign in to comment.