Skip to content

Commit

Permalink
Blue Billywig Adapter: add advertiserDomains support (#6927)
Browse files Browse the repository at this point in the history
* add Blue Billywig adapter

* Blue Billywig Adapter - update according to review feedback

* Blue Billywig Adapter - update to try and pass CircleCI

* Remove the last for .. of in bluebillywigBidAdapter.js, hopefully...

* Update bluebillywigBidAdapter test parameters to match renderer to rendererCode rename

* Blue Billywig - Also pass through site config with OpenRTB request

* add Blue Billywig adapter

* Blue Billywig Adapter - update according to review feedback

* Blue Billywig Adapter - update to try and pass CircleCI

* Remove the last for .. of in bluebillywigBidAdapter.js, hopefully...

* Code quality update, always hit user syncs, improved video params

* Add support for meta.advertiserDomains to BB Adapter, addresses issue #6466

* kick off circleci tests

Co-authored-by: Klaas-Jan Boon <klaas-janboon@ip-172-16-224-85.eu-west-1.compute.internal>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
  • Loading branch information
3 people authored Jun 3, 2021
1 parent 589bc3f commit 65975d3
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
5 changes: 3 additions & 2 deletions modules/bluebillywigBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { createEidsArray } from './userId/eids.js';

const DEV_MODE = window.location.search.match(/bbpbs_debug=true/);

// Blue Billywig Constants
// Blue Billywig Constants
const BB_CONSTANTS = {
BIDDER_CODE: 'bluebillywig',
AUCTION_URL: '$$URL_STARTpbs.bluebillywig.com/openrtb2/auction?pub=$$PUBLICATION',
Expand Down Expand Up @@ -122,7 +122,8 @@ const BB_HELPERS = {
if (!bidObject.vastUrl && bid.nurl && !bid.adm) { // ad markup is on win notice url, and adm is ommited according to OpenRTB 2.5
bidObject.vastUrl = bid.nurl;
}

bidObject.meta = bid.meta || {};
if (bid.adomain) { bidObject.meta.advertiserDomains = bid.adomain; }
return bidObject;
},
};
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions test/spec/modules/bluebillywigBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -760,6 +760,10 @@ describe('BlueBillywigAdapter', () => {
expect(bid.currency).to.equal(serverResponse.body.cur);
expect(bid.ttl).to.equal(BB_CONSTANTS.DEFAULT_TTL);

expect(bid).to.have.property('meta');
expect(bid.meta).to.have.property('advertiserDomains');
expect(bid.meta.advertiserDomains[0]).to.equal('bluebillywig.com');

expect(bid.publicationName).to.equal(validBidderRequest.bids[0].params.publicationName);
expect(bid.rendererCode).to.equal(validBidderRequest.bids[0].params.rendererCode);
expect(bid.accountId).to.equal(validBidderRequest.bids[0].params.accountId);
Expand Down

0 comments on commit 65975d3

Please sign in to comment.