From 7f0a56ba06ebca94ec61973bc671fc246e15a4a1 Mon Sep 17 00:00:00 2001 From: natexo-technical-team <91968830+natexo-technical-team@users.noreply.github.com> Date: Mon, 9 May 2022 21:17:58 +0200 Subject: [PATCH] talkads Bid Adapter: update params access in case of different ad servers (#8390) * Update talkadsBidAdapter.js Update params access * Update talkadsBidAdapter.js update functions headers * Update talkadsBidAdapter.js Delete params attribute * Update talkadsBidAdapter_spec.js Delete params attribute --- modules/talkadsBidAdapter.js | 13 ++++++++----- test/spec/modules/talkadsBidAdapter_spec.js | 4 +++- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/modules/talkadsBidAdapter.js b/modules/talkadsBidAdapter.js index 068dce23b43..dae452b9a7d 100644 --- a/modules/talkadsBidAdapter.js +++ b/modules/talkadsBidAdapter.js @@ -5,11 +5,12 @@ import {ajax} from '../src/ajax.js'; const CURRENCY = 'EUR'; const BIDDER_CODE = 'talkads'; +const GVLID = 1074; export const spec = { code: BIDDER_CODE, + gvlid: GVLID, supportedMediaTypes: [ NATIVE, BANNER ], - params: null, /** * Determines whether or not the given bid request is valid. @@ -31,7 +32,7 @@ export const spec = { utils.logError('VALIDATION FAILED : the parameter "bidder_url" must be defined'); return false; } - this.params = poBid.params; + return !!(poBid.nativeParams || poBid.sizes); }, // isBidRequestValid @@ -54,6 +55,7 @@ export const spec = { } return loOne; }); + let laParams = paValidBidRequests[0].params; const loServerRequest = { cur: CURRENCY, timeout: poBidderRequest.timeout, @@ -71,7 +73,7 @@ export const spec = { loServerRequest.gdpr.consent = poBidderRequest.gdprConsent.consentString; } } - const lsUrl = this.params.bidder_url + '/' + this.params.tag_id; + const lsUrl = laParams.bidder_url + '/' + laParams.tag_id; return { method: 'POST', url: lsUrl, @@ -86,7 +88,7 @@ export const spec = { * @param poPidRequest Request original server request * @return An array of bids which were nested inside the server. */ - interpretResponse: (poServerResponse, poPidRequest) => { + interpretResponse: function (poServerResponse, poPidRequest) { utils.logInfo('interpretResponse : ', poServerResponse); if (!poServerResponse.body) { return []; @@ -120,8 +122,9 @@ export const spec = { */ onBidWon: function (poBid) { utils.logInfo('onBidWon : ', poBid); + let laParams = poBid.params[0]; if (poBid.pbid) { - ajax(this.params.bidder_url + 'won/' + poBid.pbid); + ajax(laParams.bidder_url + 'won/' + poBid.pbid); } }, // onBidWon }; diff --git a/test/spec/modules/talkadsBidAdapter_spec.js b/test/spec/modules/talkadsBidAdapter_spec.js index 00f52ba7b6a..c48808cbc15 100644 --- a/test/spec/modules/talkadsBidAdapter_spec.js +++ b/test/spec/modules/talkadsBidAdapter_spec.js @@ -207,6 +207,7 @@ describe('TalkAds adapter', function () { ttl: 60, creativeId: 'c123a456', netRevenue: false, + params: [Object.assign({}, commonBidRequest.params)], } spec.onBidWon(loBid) expect(server.requests.length).to.equals(0); @@ -222,7 +223,8 @@ describe('TalkAds adapter', function () { ttl: 60, creativeId: 'c123a456', netRevenue: false, - pbid: '6147833a65749742875ace47' + pbid: '6147833a65749742875ace47', + params: [Object.assign({}, commonBidRequest.params)], } spec.onBidWon(loBid) expect(server.requests[0].url).to.equals('https://test.natexo-programmatic.com/tad/tag/prebidwon/6147833a65749742875ace47');