From 66cbea9267e26a590266ba6002ccb8c7809d3f2b Mon Sep 17 00:00:00 2001 From: hjeong12 Date: Tue, 8 Dec 2015 10:53:56 +0900 Subject: [PATCH 1/2] fixed contentWindow for safari and edge --- src/adapters/rubicon.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/adapters/rubicon.js b/src/adapters/rubicon.js index ee8a6a7e032..5926b56b141 100644 --- a/src/adapters/rubicon.js +++ b/src/adapters/rubicon.js @@ -122,7 +122,13 @@ var RubiconAdapter = function RubiconAdapter() { var height = 0; var iframeObj = window.frames[iframeId]; - var rubiconObj = iframeObj.contentWindow.RubiconAdServing; + var rubiconObj; + if(iframeObj.contentWindow){ + rubiconObj = iframeObj.contentWindow.RubiconAdServing + }else{ + rubiconObj = iframeObj.window.RubiconAdServing; + } + if (rubiconObj && rubiconObj.AdSizes) { /* should return 1: { From 0bfcfa7cdd935f3ee8924618ee4e6ddbaceb5d22 Mon Sep 17 00:00:00 2001 From: hjeong12 Date: Tue, 8 Dec 2015 15:05:33 +0900 Subject: [PATCH 2/2] added validation for ads.status --- src/adapters/rubicon.js | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/adapters/rubicon.js b/src/adapters/rubicon.js index 5926b56b141..1462e53f266 100644 --- a/src/adapters/rubicon.js +++ b/src/adapters/rubicon.js @@ -113,9 +113,9 @@ var RubiconAdapter = function RubiconAdapter() { iframeId = bidObj.iframeId; } - bid = bidfactory.createBid(1); + if (response.ads && response.ads[0] && response.ads[0].status === 'ok') { + bid = bidfactory.createBid(1); - if (response.ads && response.ads[0]) { var rubiconAd = response.ads[0]; var size = sizeMap[rubiconAd.size_id]; var width = 0; @@ -148,6 +148,14 @@ var RubiconAdapter = function RubiconAdapter() { bid.sizeId = rubiconAd.size_id; bid.width = width; bid.height = height; + + }else{ + bid = bidfactory.createBid(2); + bid.bidderCode = 'rubicon'; + var bidObj = bidmanager.getPlacementIdByCBIdentifer(getBidId(response)); + if (bidObj) { + placementCode = bidObj.placementCode; + } } } catch (e) {