Skip to content

Commit

Permalink
drop support for userId configs with the usersync config object (#5427
Browse files Browse the repository at this point in the history
)

* drop support for userId configs with the `usersync` config object, per deprecation notice

* changes on drop support (#1)

* Update userIdTargeting.md

* Update userId.md

* Update userId_spec.js

* Update britepoolIdSystem.md

* Update sharedIdSystem.md

Co-authored-by: Patrick McCann <patmmccann@gmail.com>
  • Loading branch information
smenzer and patmmccann authored Jul 21, 2020
1 parent 13a347a commit d99e637
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion modules/britepoolIdSystem.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ BritePool User ID Module. For assistance setting up your module please contact u
Individual params may be set for the BritePool User ID Submodule. At least one identifier must be set in the params.
```
pbjs.setConfig({
usersync: {
userSync: {
userIds: [{
name: 'britepoolId',
storage: {
Expand Down
2 changes: 1 addition & 1 deletion modules/sharedIdSystem.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ ex: $ gulp build --modules=userId,sharedIdSystem
Individual params may be set for the Shared ID User ID Submodule.
```
pbjs.setConfig({
usersync: {
userSync: {
userIds: [{
name: 'sharedId',
params: {
Expand Down
4 changes: 2 additions & 2 deletions modules/userId/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -576,8 +576,8 @@ export function init(config) {
}
// listen for config userSyncs to be set
config.getConfig(conf => {
// Note: support for both 'userSync' and 'usersync' will be deprecated with Prebid.js 3.0
const userSync = conf.userSync || conf.usersync;
// Note: support for 'usersync' was dropped as part of Prebid.js 4.0
const userSync = conf.userSync;
if (userSync && userSync.userIds) {
configRegistry = userSync.userIds;
syncDelay = utils.isNumber(userSync.syncDelay) ? userSync.syncDelay : DEFAULT_SYNC_DELAY;
Expand Down
4 changes: 2 additions & 2 deletions modules/userId/userId.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ pbjs.setConfig({
Example showing `localStorage` for user id data for some submodules
```
pbjs.setConfig({
usersync: {
userSync: {
userIds: [{
name: "unifiedId",
params: {
Expand Down Expand Up @@ -137,7 +137,7 @@ pbjs.setConfig({
Example showing how to configure a `value` object to pass directly to bid adapters
```
pbjs.setConfig({
usersync: {
userSync: {
userIds: [{
name: "pubCommonId",
value: {
Expand Down
2 changes: 1 addition & 1 deletion modules/userIdTargeting.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ pbjs.setConfig({
// your existing userIds config
usersync: {
userSync: {
userIds: [{...}, ...]
},
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/userId_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ describe('User ID', function() {
it('does not delay auction if there are no ids to fetch', function() {
coreStorage.getCookie.withArgs('MOCKID').returns('123456778');
config.setConfig({
usersync: {
userSync: {
auctionDelay: 33,
syncDelay: 77,
userIds: [{
Expand Down

0 comments on commit d99e637

Please sign in to comment.