review

prebid · Oct 5, 2020 · f035cd2 · f035cd2
1 parent 08bb298
commit f035cd2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/modules/teadsBidAdapter.js b/modules/teadsBidAdapter.js
@@ -133,8 +133,8 @@ function getTimeToFirstByte(win) {
     performance.getEntriesByType('navigation')[0] &&
     performance.getEntriesByType('navigation')[0].responseStart &&
     performance.getEntriesByType('navigation')[0].requestStart &&
-    performance.getEntriesByType('navigation')[0].responseStart >= 0 &&
-    performance.getEntriesByType('navigation')[0].requestStart >= 0 &&
+    performance.getEntriesByType('navigation')[0].responseStart > 0 &&
+    performance.getEntriesByType('navigation')[0].requestStart > 0 &&
     Math.round(
       performance.getEntriesByType('navigation')[0].responseStart - performance.getEntriesByType('navigation')[0].requestStart
     );
@@ -146,8 +146,8 @@ function getTimeToFirstByte(win) {
   const ttfbWithTimingV1 = performance &&
     performance.timing.responseStart &&
     performance.timing.requestStart &&
-    performance.timing.responseStart >= 0 &&
-    performance.timing.requestStart >= 0 &&
+    performance.timing.responseStart > 0 &&
+    performance.timing.requestStart > 0 &&
     performance.timing.responseStart - performance.timing.requestStart;
 
   return ttfbWithTimingV1 ? ttfbWithTimingV1.toString() : '';

diff --git a/test/spec/modules/teadsBidAdapter_spec.js b/test/spec/modules/teadsBidAdapter_spec.js
@@ -200,8 +200,8 @@ describe('teadsBidAdapter', () => {
         performance.getEntriesByType('navigation')[0] &&
         performance.getEntriesByType('navigation')[0].responseStart &&
         performance.getEntriesByType('navigation')[0].requestStart &&
-        performance.getEntriesByType('navigation')[0].responseStart >= 0 &&
-        performance.getEntriesByType('navigation')[0].requestStart >= 0 &&
+        performance.getEntriesByType('navigation')[0].responseStart > 0 &&
+        performance.getEntriesByType('navigation')[0].requestStart > 0 &&
         Math.round(
           performance.getEntriesByType('navigation')[0].responseStart - performance.getEntriesByType('navigation')[0].requestStart
         );
@@ -214,8 +214,8 @@ describe('teadsBidAdapter', () => {
         const ttfbWithTimingV1 = performance &&
             performance.timing.responseStart &&
             performance.timing.requestStart &&
-            performance.timing.responseStart >= 0 &&
-            performance.timing.requestStart >= 0 &&
+            performance.timing.responseStart > 0 &&
+            performance.timing.requestStart > 0 &&
             performance.timing.responseStart - performance.timing.requestStart;
         const ttfbExpectedV1 = ttfbWithTimingV1 ? ttfbWithTimingV1.toString() : '';