From fb045f838f02ea28170d6aff496a72bf4b986c54 Mon Sep 17 00:00:00 2001 From: Matt Lane Date: Mon, 22 Jan 2018 15:10:40 -0800 Subject: [PATCH] Update spportedMediaTypes to include banner for adapters that were implicitly supporting banner --- modules/adkernelAdnBidAdapter.js | 2 +- modules/adkernelBidAdapter.js | 2 +- modules/adxcgBidAdapter.js | 4 ++-- modules/audienceNetworkBidAdapter.js | 2 +- modules/conversantBidAdapter.js | 4 ++-- modules/freewheelSSPBidAdapter.js | 2 +- modules/pulsepointBidAdapter.js | 2 +- modules/rubiconBidAdapter.js | 2 +- modules/sekindoUMBidAdapter.js | 2 +- test/spec/modules/audienceNetworkBidAdapter_spec.js | 2 +- test/spec/modules/conversantBidAdapter_spec.js | 4 ++-- test/spec/modules/pulsepointBidAdapter_spec.js | 4 ++-- 12 files changed, 16 insertions(+), 16 deletions(-) diff --git a/modules/adkernelAdnBidAdapter.js b/modules/adkernelAdnBidAdapter.js index 28fb564320d..c02a0cb138f 100644 --- a/modules/adkernelAdnBidAdapter.js +++ b/modules/adkernelAdnBidAdapter.js @@ -80,7 +80,7 @@ export const spec = { code: 'adkernelAdn', - supportedMediaTypes: [VIDEO], + supportedMediaTypes: [BANNER, VIDEO], isBidRequestValid: function(bidRequest) { return 'params' in bidRequest && (typeof bidRequest.params.host === 'undefined' || typeof bidRequest.params.host === 'string') && diff --git a/modules/adkernelBidAdapter.js b/modules/adkernelBidAdapter.js index 016cc5794fb..c3f34274692 100644 --- a/modules/adkernelBidAdapter.js +++ b/modules/adkernelBidAdapter.js @@ -16,7 +16,7 @@ export const spec = { code: 'adkernel', aliases: ['headbidding'], - supportedMediaTypes: [VIDEO], + supportedMediaTypes: [BANNER, VIDEO], isBidRequestValid: function(bidRequest) { return 'params' in bidRequest && typeof bidRequest.params.host !== 'undefined' && 'zoneId' in bidRequest.params && !isNaN(Number(bidRequest.params.zoneId)); diff --git a/modules/adxcgBidAdapter.js b/modules/adxcgBidAdapter.js index 44b1f381bbe..91bf0746afc 100644 --- a/modules/adxcgBidAdapter.js +++ b/modules/adxcgBidAdapter.js @@ -1,7 +1,7 @@ import * as utils from 'src/utils'; import * as url from 'src/url'; import {registerBidder} from 'src/adapters/bidderFactory'; -import {NATIVE, VIDEO} from 'src/mediaTypes'; +import {BANNER, NATIVE, VIDEO} from 'src/mediaTypes'; /** * Adapter for requesting bids from adxcg.net @@ -9,7 +9,7 @@ import {NATIVE, VIDEO} from 'src/mediaTypes'; */ const BIDDER_CODE = 'adxcg'; -const SUPPORTED_AD_TYPES = [VIDEO, NATIVE]; +const SUPPORTED_AD_TYPES = [BANNER, VIDEO, NATIVE]; const SOURCE = 'pbjs10'; export const spec = { code: BIDDER_CODE, diff --git a/modules/audienceNetworkBidAdapter.js b/modules/audienceNetworkBidAdapter.js index 41ca539ccba..2b0e4cd8190 100644 --- a/modules/audienceNetworkBidAdapter.js +++ b/modules/audienceNetworkBidAdapter.js @@ -12,7 +12,7 @@ const code = 'audienceNetwork'; const currency = 'USD'; const method = 'GET'; const url = 'https://an.facebook.com/v2/placementbid.json'; -const supportedMediaTypes = ['video']; +const supportedMediaTypes = ['banner', 'video']; const netRevenue = true; const hb_bidder = 'fan'; diff --git a/modules/conversantBidAdapter.js b/modules/conversantBidAdapter.js index 1f6c4f27b77..cae64983089 100644 --- a/modules/conversantBidAdapter.js +++ b/modules/conversantBidAdapter.js @@ -1,6 +1,6 @@ import * as utils from 'src/utils'; import {registerBidder} from 'src/adapters/bidderFactory'; -import { VIDEO } from 'src/mediaTypes'; +import { BANNER, VIDEO } from 'src/mediaTypes'; const BIDDER_CODE = 'conversant'; const URL = '//media.msg.dotomi.com/s2s/header/24'; @@ -10,7 +10,7 @@ const VERSION = '2.2.1'; export const spec = { code: BIDDER_CODE, aliases: ['cnvr'], // short code - supportedMediaTypes: [VIDEO], + supportedMediaTypes: [BANNER, VIDEO], /** * Determines whether or not the given bid request is valid. diff --git a/modules/freewheelSSPBidAdapter.js b/modules/freewheelSSPBidAdapter.js index 64ebb36478b..632df8fe93c 100644 --- a/modules/freewheelSSPBidAdapter.js +++ b/modules/freewheelSSPBidAdapter.js @@ -190,7 +190,7 @@ var getOutstreamScript = function(bid) { export const spec = { code: BIDDER_CODE, - supportedMediaTypes: ['video'], + supportedMediaTypes: ['banner', 'video'], aliases: ['stickyadstv'], // former name for freewheel-ssp /** * Determines whether or not the given bid request is valid. diff --git a/modules/pulsepointBidAdapter.js b/modules/pulsepointBidAdapter.js index 2c1f6f9174d..fc637cc9fff 100644 --- a/modules/pulsepointBidAdapter.js +++ b/modules/pulsepointBidAdapter.js @@ -28,7 +28,7 @@ export const spec = { aliases: ['pulseLite', 'pulsepointLite'], - supportedMediaTypes: ['native'], + supportedMediaTypes: ['banner', 'native'], isBidRequestValid: bid => ( !!(bid && bid.params && bid.params.cp && bid.params.ct) diff --git a/modules/rubiconBidAdapter.js b/modules/rubiconBidAdapter.js index 76a9095be72..1e7762ae90d 100644 --- a/modules/rubiconBidAdapter.js +++ b/modules/rubiconBidAdapter.js @@ -73,7 +73,7 @@ utils._each(sizeMap, (item, key) => sizeMap[item] = key); export const spec = { code: 'rubicon', aliases: ['rubiconLite'], - supportedMediaTypes: ['video'], + supportedMediaTypes: ['banner', 'video'], /** * @param {object} bid * @return boolean diff --git a/modules/sekindoUMBidAdapter.js b/modules/sekindoUMBidAdapter.js index 6e4ae34bd76..09b94be967b 100644 --- a/modules/sekindoUMBidAdapter.js +++ b/modules/sekindoUMBidAdapter.js @@ -2,7 +2,7 @@ import * as utils from 'src/utils'; import {registerBidder} from 'src/adapters/bidderFactory'; export const spec = { code: 'sekindoUM', - supportedMediaTypes: ['video'], + supportedMediaTypes: ['banner', 'video'], /** * Determines whether or not the given bid request is valid. * diff --git a/test/spec/modules/audienceNetworkBidAdapter_spec.js b/test/spec/modules/audienceNetworkBidAdapter_spec.js index b153a58eeb0..cabcdce46f2 100644 --- a/test/spec/modules/audienceNetworkBidAdapter_spec.js +++ b/test/spec/modules/audienceNetworkBidAdapter_spec.js @@ -25,7 +25,7 @@ describe('AudienceNetwork adapter', () => { expect(code).to.equal(bidder); }); it('supportedMediaTypes', () => { - expect(supportedMediaTypes).to.deep.equal(['video']); + expect(supportedMediaTypes).to.deep.equal(['banner', 'video']); }); it('isBidRequestValid', () => { expect(isBidRequestValid).to.be.a('function'); diff --git a/test/spec/modules/conversantBidAdapter_spec.js b/test/spec/modules/conversantBidAdapter_spec.js index c99cad473a3..9f7cb3ff17d 100644 --- a/test/spec/modules/conversantBidAdapter_spec.js +++ b/test/spec/modules/conversantBidAdapter_spec.js @@ -116,8 +116,8 @@ describe('Conversant adapter tests', function() { expect(spec.code).to.equal('conversant'); expect(spec.aliases).to.be.an('array').with.lengthOf(1); expect(spec.aliases[0]).to.equal('cnvr'); - expect(spec.supportedMediaTypes).to.be.an('array').with.lengthOf(1); - expect(spec.supportedMediaTypes[0]).to.equal('video'); + expect(spec.supportedMediaTypes).to.be.an('array').with.lengthOf(2); + expect(spec.supportedMediaTypes[1]).to.equal('video'); }); it('Verify user syncs', function() { diff --git a/test/spec/modules/pulsepointBidAdapter_spec.js b/test/spec/modules/pulsepointBidAdapter_spec.js index cb99f1b5d98..933b65c4574 100644 --- a/test/spec/modules/pulsepointBidAdapter_spec.js +++ b/test/spec/modules/pulsepointBidAdapter_spec.js @@ -228,8 +228,8 @@ describe('PulsePoint Adapter Tests', () => { }); it('Verifies supported media types', () => { - expect(spec.supportedMediaTypes).to.have.lengthOf(1); - expect(spec.supportedMediaTypes[0]).to.equal('native'); + expect(spec.supportedMediaTypes).to.have.lengthOf(2); + expect(spec.supportedMediaTypes[1]).to.equal('native'); }); it('Verifies if bid request valid', () => {