Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UID2: use our http methods #10325

Closed
patmmccann opened this issue Aug 7, 2023 · 2 comments
Closed

UID2: use our http methods #10325

patmmccann opened this issue Aug 7, 2023 · 2 comments
Labels
9.0 API Change bug

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Aug 7, 2023 •
edited
Loading

#8421 identified most adapters not using our methods. Another seems to have appeared with https://github.com/prebid/Prebid.js/pull/9264/files

From the comments on that, one may find many examples of a fix

      > Thanks @patmmccann for pointing this out. Can you direct us to the correct method definition in the docs? Thanks

2a05213 is an example; using the loadExternalScript utility

Originally posted by @patmmccann in #8421 (comment)

@lionell-pack-ttd as fyi
@patmmccann patmmccann changed the title UID2: use out methods UID2: use our http methods Aug 7, 2023
@patmmccann patmmccann moved this from Triage to Needs OP in Prebid.js Tactical Issues table Aug 14, 2023
@patmmccann patmmccann added the bug label Sep 11, 2023
@patmmccann
Copy link
Collaborator Author

@lionell-pack-ttd as reminder, you need to sort this out by prebid 9

@patmmccann patmmccann moved this from Needs OP to Tracking in Prebid.js Tactical Issues table Dec 4, 2023
@patmmccann
Copy link
Collaborator Author

this was fixed in d0e981b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
9.0 API Change bug
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patmmccann