url: null when using url: encodeURIComponent(window.location.href) with dfpAdServerVideo module - video

[spormeon]

Type of issue

I think the fix in #10575 now leads url: null, if using: url: encodeURIComponent(window.location.href),

Description

using: url: encodeURIComponent(window.location.href), to auto pick out the page url, now leads to url: null, an offset of #10575 fix , I think

description_url: encodeURIComponent(window.location.href), still works and return the correct "page url"

Steps to reproduce

hard code the url and still works as expected:

Also does it , if you dont set "url" at all, which is ment to allow ima sdk to "fetch the url" on its own, sort of the "default ima sdk" setting:

Platform details

mac, chrome, P 8.18.0

Other information

[karimMourra]

Unassigning myself; based on the code changes, it's not clear that this is caused by #10575

function getDescriptionUrl(bid, components, prop) {
  return deepAccess(components, `${prop}.description_url`) || encodeURIComponent(dep.ri().page);
}

it doesn't seem like encodeURIComponent(dep.ri().page) would even get called in this scenario.

[spormeon]

i've actually been back to P7.37.0 and still does it then, might of just been completely luck found it when testing 8.18.0 and thought had something to do with 10575, it could go way way way back

[spormeon]

cant you apply what did with "description_url" and relate it to "url", as description_url works with: description_url: encodeURIComponent(window.location.href), & description_url: 'https://test.com',

[dgirardi]

@spormeon I don't understand how to reproduce this. Is it consistent? With what configuration?

[spormeon]

the bidsbackhandler video demo in repo gets you it, if add a line to the params: url:encodeURIComponent(window.location.href),
if hard code
url: 'https://test.com', it will work

search ima in consule, get/ see the url with the video tag sent on it, check "payload"

p.s. not on my usual machine, so cant post you it to look at , at mo

[patmmccann]

@spormeon we're having trouble making heads or tails out of your steps to reproduce. Could you start over and list them in more detail?

[spormeon]

my bad on this one, its actually ima sdk doing it, perills of a non authorised (google) test domain