Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getConfig cleanup of device, app, and site in bidders #10657

Closed
patmmccann opened this issue Oct 30, 2023 · 1 comment
Closed

getConfig cleanup of device, app, and site in bidders #10657

patmmccann opened this issue Oct 30, 2023 · 1 comment
Assignees

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Oct 30, 2023

const deviceConfig = config.getConfig('device');
is an example of referencing getConfig to gather a parameter about the device. The preferred implementation follows this
device: ortb2Data?.device || {},

There are many incorrect implementations in the project.

https://github.com/search?q=repo%3Aprebid%2FPrebid.js+%22getConfig%28%27device%27%29%22&type=code

https://github.com/search?q=repo%3Aprebid%2FPrebid.js+%22getConfig%28%27site%27%29%22&type=code

https://github.com/search?q=repo%3Aprebid%2FPrebid.js+%22getConfig%28%27app%27%29%22&type=code

We no longer support site, device, nor app config directly accessed in bidders [core picks it up and puts it in ortb2, but it isn't documented]

@patmmccann patmmccann changed the title getConfig cleanup of device getConfig cleanup of device, app, and site in bidders Nov 20, 2023
@patmmccann
Copy link
Collaborator Author

replaced by #10747

@patmmccann patmmccann closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants