Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID duplication in pubprovided ids module #10793

Closed
JulianRSL opened this issue Dec 4, 2023 · 2 comments · Fixed by #10795
Closed

ID duplication in pubprovided ids module #10793

JulianRSL opened this issue Dec 4, 2023 · 2 comments · Fixed by #10795
Assignees
Labels

Comments

@JulianRSL
Copy link
Contributor

JulianRSL commented Dec 4, 2023

Type of issue

BUG

Description

Duplicated ids are added to a pubprovided IDs on every auction if identity module that provides id with the same source is present and has ids

Steps to reproduce

1.Define configuration to a pubprovided Ids module to provide 'adserver.org' (TDID) id:

function myf(){
return [
    {
        "uids": [
            {
                "ext": {
                    "stype": "ppuid"
                },
                "id": "4a958e6e-de2c-45f1-bd66-836890a2e78a"
            }
        ],
        "source": "adserver.org"
    }
]
}

pbjs.setConfig({
     userSync: {
         userIds: [{
             name: "pubProvidedId",
             params: {
                 eidsFunction: myf   // any function that exists in the page
             }
         }]
     }
 });

2.Configure unified ids module to provide id:

pbjs.setConfig({
     userSync: {
         userIds: [{
             name: "unifiedId",
             value: {"tdid": "D6885E90-2A7A-4E0F-87CB-7734ED1B99A3"}
         }]
     }
 });

3.Run an auction

Test page

https://jsfiddle.net/6te4Ly81/

Expected results

After running any amount of auctions amount of ids in pubprovided supposed to be the same if no additional configuration was added.

JSON value of pubprovidedId : '[{"uids":[{"ext":{"stype":"ppuid"},"id":"4a958e6e-de2c-45f1-bd66-836890a2e78a"}],"source":"adserver.org"}]'

(could be simulated on a page by selecting prebid 8.14)

Actual results

Additional ids added to pubprovided ids list (duplications from ids provided by identity module)
JSON value for pubProvidedId: '[{"uids":[{"ext":{"stype":"ppuid"},"id":"4a958e6e-de2c-45f1-bd66-836890a2e78a"},{"id":"XXXXXXXX-XXXX-XXXX-XXXX-7734ED1B99A3","atype":1,"ext":{"rtiPartner":"TDID"}},{"id":"XXXXXXXX-XXXX-XXXX-XXXX-7734ED1B99A3","atype":1,"ext":{"rtiPartner":"TDID"}},{"id":"XXXXXXXX-XXXX-XXXX-XXXX-7734ED1B99A3","atype":1,"ext":{"rtiPartner":"TDID"}},{"id":"XXXXXXXX-XXXX-XXXX-XXXX-7734ED1B99A3","atype":1,"ext":{"rtiPartner":"TDID"}}],"source":"adserver.org"}]'

(could be simulated on a page by selecting prebid 8.15)

Platform details

Prebid.js version >= 8.15

Other information

Suspected to be related to :
425cf20

Case study:
Prebid bug introduced starting version 8 15.pdf

@patmmccann
Copy link
Collaborator

Can you please hash out expected and actual results with jsons

@JulianRSL
Copy link
Contributor Author

Added to a bug description

@patmmccann patmmccann moved this from Ready for Dev to PR submitted in Prebid.js Tactical Issues table Dec 6, 2023
@github-project-automation github-project-automation bot moved this from PR submitted to Done in Prebid.js Tactical Issues table Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants