Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better s2sConfig.timeout defaults #10989

Closed
patmmccann opened this issue Jan 25, 2024 · 1 comment
Closed

Better s2sConfig.timeout defaults #10989

patmmccann opened this issue Jan 25, 2024 · 1 comment
Assignees
@dgirardi
Labels
9.0 API Change

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Jan 25, 2024 •
edited
Loading

Type of issue

feature

Description

pbs adapter sets tmax to timeout, we should set it to minimum (timeout * .75, 750) assuming the publisher has not explicitly set it
@patmmccann patmmccann moved this from Triage to Blocked in Prebid.js Tactical Issues table Jan 29, 2024
@patmmccann patmmccann moved this from Blocked to Ready for Dev in Prebid.js Tactical Issues table May 9, 2024
@patmmccann
Copy link
Collaborator Author

@robertrmartinez any feedback on this choice?

@dgirardi dgirardi self-assigned this May 29, 2024
@dgirardi dgirardi mentioned this issue May 29, 2024
Merged
1 task
@github-project-automation github-project-automation bot moved this from Ready for Dev to Done in Prebid.js Tactical Issues table May 30, 2024
@dgirardi dgirardi mentioned this issue Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgirardi dgirardi

Labels
9.0 API Change
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patmmccann @dgirardi