Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

¿Que? #1124

Closed
matthewoates opened this issue Apr 12, 2017 · 4 comments · Fixed by #1156
Closed

¿Que? #1124

matthewoates opened this issue Apr 12, 2017 · 4 comments · Fixed by #1156
Assignees

Comments

@matthewoates
Copy link

Type of issue

Naming/API

Description

Trivial gripe, but are we interested in renaming/aliasing the pbjs.que to pbjs.queue?

see: https://www.merriam-webster.com/dictionary/Que

@ericso
Copy link

ericso commented Apr 12, 2017

👍

@snapwich
Copy link
Collaborator

If we do update it, I'd suggest just changing it to cmd like googletag uses. Just as short without the ¿Wat?

@mkendall07
Copy link
Member

Believe it or not, this was intentional - just to make the code shorter. Maybe not everyone appreciates it but it's documented sufficiently.

With that said, I'm fine to make an alias to the function at pbjs.queue as well so we don't break existing pages. Feel free to submit a PR.

@mkendall07
Copy link
Member

or cmd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants