-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paapi Module: Autoconfig behavior #11242
Comments
Another solution is we just tell pubs not to make this mistake. We could potentially warn them if they request bids on a slot thrice but only called pbjs.setPAAPIConfigForGPT() once Thanks for flagging as relevant to #11102 |
Let's close issue #11102 and continue discussions within this ticket since it contains most of the relevant context. |
Sounds good, ty! |
One thought: if we start handing auction configs to gam or another TLS before targeting is ready, marrying them together might present some challenges as we try and solve for latency |
Spoke with the GAM team, a 'allAuctionConfigAreSubmitted' function might be coming to GPT. That would make marrying these more difficult if publishers plan to take advantage. |
Consensus - provide this feature request with a new name and delete the autoconfig feature. |
Reviewing the MR, it looks like the issue of cached auction configurations has not yet been addressed. As long as |
That's covered in #10930 |
@lksharma we're chatting about this and realizing we may have achieved your goals; where do we go from here? |
Agreed. I've also recently updated the documentation to reflect this case as well: prebid/prebid.github.io#5526. I think we are good to close this out. Thanks. |
Description
Prebid version 8.37.0 introduced new features allowing auction configurations to be independent of GPT. This version also introduced functionality to clear cached auction configurations by resetting them with null values using setConfig. However, in certain scenarios, cached auction configurations can persist, leading to duplicate impression calls, as observed in version 8.36.0. This ticket also provides additional context to issue #11102 which is pending discussions on the desired default autoconfig behaviour.
Issue Details
fledgeForGpt.autoconfig
set to true (default), cached auction configurations are reset correctly.fledgeForGpt.autoconfig
is set to false, additional API calls are required to trigger on-device auctions.pbjs.setPAAPIConfigForGPT()
whenever pbjs.requestBids is invoked and ensure it's called within thebidsBackHandler
function.Problem Scenario:
If the publisher neglects to call
pbjs.setPAAPIConfigForGPT(
) for subsequent refresh calls, Prebid does not reset the previously set auction configuration, leading to potential duplicate impression calls.Example Setup:
Steps to Reproduce:
pbjs.requestBids
and callpbjs.setPAAPIConfigForGPT()
in thebidsBackHandler
functionpbjs.setPAAPIConfigForGPT()
Potential Solution:
Previously set auction configs are reset by the logic within the slotConfigurator function, which executes when
pbjs.setPAAPIConfigForGPT()
is called. Automatingpbjs.setPAAPIConfigForGPT()
calls withinsetTargetingForGPTAsync()
or similar functions could reduce the likelihood of configuration errors and mitigate potential duplicate impression calls.The text was updated successfully, but these errors were encountered: