Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bids requests failing if bidder missing #1137

Closed
AntoineJac opened this issue Apr 19, 2017 · 1 comment · Fixed by #1815
Closed

Bids requests failing if bidder missing #1137

AntoineJac opened this issue Apr 19, 2017 · 1 comment · Fixed by #1815
Assignees
Labels

Comments

@AntoineJac
Copy link
Contributor

Bug: Bids not trigger if a bidder is missing in the prebid.js file

Description

When settings the videoAdUnit parameters, if one of the bidder is not present in the Prebid.js file, it will make all the request crash... I have tested with the display and if a bidder is not present, other calls are still and correctly made.

Steps to reproduce

Please reach the following page where some random Appnexus and Rubicon parameters. The prebid.js has been built with only Rubicon adapter. As you will see no requests are made:
http://legba.alwaysdata.net/VideoR.html

I have used exactly the same code with a prebid.js built this time with Rubicon and Appnexus adapters. As you will see this time everything is ok:
http://legba.alwaysdata.net/VideoRA.html

Expected results

If a bidder is not present in the prebid.js tag, it should skip it but still make the call for the others bidders.

Actual results

All requests are skipped.

Platform details

The last version 0.21.0

Other information

@matthewlane matthewlane self-assigned this Apr 21, 2017
@matthewlane
Copy link
Collaborator

I've made a note to fix this, though feel free to open a PR if you'd like. Thanks for the report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants