onTimeout() fired for bids recieved before Auction Timeout.

[dqureshiumar]

Type of issue

Bug

Description

We are recording onTimeout() event getting called for all bidders, if any of the bidder's bid in current auction times out.

Test page

https://jsfiddle.net/umerrqq/t61e2zkm/4/

Steps to reproduce

In Chrome Developer Tools enable Network Throttling to Slow 3g for timing out bidders

We are using bidders who have implemented onBidWon and onTimeout events in their respective Bid Adapter

1. Media.net Bid Adapter
2. AdQuery Bid Adapter

Case 1:

Media.net Bidder Won (mocked Bid) - onTimeout and onBidWon event is fired for the same bidder

Case 2:

Ad Query Bidder Won(mocked Bid) - onTimeout and onBidWon event is fired for the same bidder

Prebid Events

1. Bid Timeout Event - The below image shows adquery bidder’s snm appears is TIMEOUT
   

2. Auction End Event - in auctionEnd event, under bidsReceived array, the bidder's snm is RENDERED.
   

Expected results

onBidWon should've fired and NOT the onTimeout event

Actual results

Both onBidWon and onTimeout events got fired.

Platform details

Prebid 9.11.0

Other Information

1. To mock a Bidder Response, we are using Professor Prebid chrome extension
2. Additionally use ModResponse to throttle a specific bidder

[dqureshiumar]

@dgirardi Since you are the last committer of the file, perhaps you can help us further debug this issue.

[dgirardi]

There's a bug in the debugging module where a bidder which is "completely" mocked out (where no actual network request for it is generated) will never be considered "timely" and, if the auction times out, will always appear in the list of timed out bidders / its onTimeout handler will be invoked. It should be fixed with #12177.

However, this should not affect "real" bids. Let me know if this was a red herring hiding some other timeout issue.

[ChrisHuie]

Closing with merged pr #12177