Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several dependencies still use babel-core@6.XX that uses JSON5 in an vulnerable version #12258

Closed
renebaudisch opened this issue Sep 19, 2024 · 2 comments · Fixed by #12259
Closed

Comments

@renebaudisch
Copy link
Contributor

Type of issue

Security vulnerability

Description

A scan of the node_modules folder of Prebis.js revealed a major security issue.
The library json5 version 0.5.1 was detected in NPM library manager located at
./Prebid.js/node_modules/babel-core/node_modules/json5/package.json
and is vulnerable to CVE-2022-46175, which exists in versions < 1.0.2.
See also GHSA-9c47-m6qq-7p4h

This is not because of the babel-core used by Prebid.js itself but by it's dependencies,
like babel-register as mentioned in ISSUE 12010 but also coming through e.g. eslint-plugin-import.
This shows all packages that in itself depend on babel-core@6.XX:

image

Platform details

This affects at leastv9 (latest) of Prebid.js

Other information

Partly already mentioned in:
ISSUE 12010

@dgirardi
Copy link
Collaborator

Is this not a duplicate of #12010 ?

demetrio@pbws2:~/src/Prebid.js$ npm ls json5@0.5.1
prebid.js@9.13.0-pre /home/demetrio/src/Prebid.js
└─┬ babel-register@6.26.0
  └─┬ babel-core@6.26.3
    └── json5@0.5.1

babel-register a dev dependency and does not affect prebid at runtime, same as in #12010. Do you have reason to think otherwise?

@renebaudisch
Copy link
Contributor Author

more or less, it seems to be related to more then just "babel-register", but does that matter? It should be fixed anyway...
But you will surely see in the PR I did.

@patmmccann patmmccann linked a pull request Sep 22, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants