Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests failing in IE 10 #1656

Closed
jaiminpanchal27 opened this issue Oct 4, 2017 · 2 comments
Closed

Unit tests failing in IE 10 #1656

jaiminpanchal27 opened this issue Oct 4, 2017 · 2 comments
Assignees
@grevory @harpere
Labels
bug

Comments

@jaiminpanchal27
Copy link
Collaborator

Type of issue

Bug

Description

Usage of __lookupSetter__ is preventing tests to run in IE 10.
https://github.com/prebid/Prebid.js/blob/master/test/spec/utils_spec.js#L530

Log:
IE 10.0.0 (Windows 8 0.0.0) ERROR
Object doesn't support property or method 'lookupSetter'
at webpack:///test/spec/utils_spec.js:530:4 <- test/spec/utils_spec.js:639

Steps to reproduce

Run tests in IE 10

Other information

@grevory @harpere
Introduced in #1229
@jaiminpanchal27 jaiminpanchal27 mentioned this issue Oct 18, 2017
Merged
9 tasks
@harpere
Copy link
Collaborator

harpere commented Dec 13, 2017

Since Prebid is no longer officially supporting IE 10, this is no longer an issue. Uncommenting these tests: #1958

@mkendall07
Copy link
Member

@harpere
Not sure we decided that yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grevory grevory

@harpere harpere

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@grevory @mkendall07 @harpere @jaiminpanchal27