Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming of Huddled Masses adapter #1685

Closed
HuddledMasses opened this issue Oct 12, 2017 · 5 comments
Closed

Renaming of Huddled Masses adapter #1685

HuddledMasses opened this issue Oct 12, 2017 · 5 comments

Comments

@HuddledMasses
Copy link
Contributor

Question

What is the process of renaming our existing Huddled Masses adapter?

Description

Hi Team, we are planning to move to new domain. What are the exact steps, requiremends to rename the adapter and how much time will it take?

Steps to reproduce

Test page

Expected results

Actual results

Platform details

Other information

@mkendall07
Copy link
Member

should be straight forward. Update your adapter with the new name, renaming the file at the same time.

Please use the prebid 1.0 adapter spec when rebuilding the adapter. http://prebid.org/dev-docs/bidder-adapter-1.html

Consider adding an alias for huddleMasses previous adapter code to the new one to help pubs transition.

@HuddledMasses
Copy link
Contributor Author

@mkendall07 thank you!
Here is our pull request: #1701
How long will it take, to review and to publish?

@mkendall07
Copy link
Member

thanks. Are you able to update to the new bidder format? See https://github.com/prebid/Prebid.js/blob/master/modules/appnexusAstBidAdapter.js for example.

That is preferred.

@dbemiller
Copy link
Contributor

I merged this. Just beware @HuddledMasses that the adapter isn't compatible with 1.0... so when we merge in the prebid-1.0 branch, it'll be deleted.

If you want it to stay in the project longer than a month or two, please submit a PR to update your adapter: http://prebid.org/dev-docs/bidder-adapter-1.html

@dbemiller
Copy link
Contributor

We're planning to release later today, so it'll be available live soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants