Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event name "bidsRequested" is written as a direct string in one case #2088

Closed
TomasRiker opened this issue Jan 31, 2018 · 0 comments
Closed
Assignees

Comments

@TomasRiker
Copy link

Type of issue

Source code "cosmetics"

Description

Please see https://github.com/prebid/Prebid.js/blob/master/src/prebid.js

You'll find the line:

events.emit('requestBids');

While all other event names are wrapped by constants, like:

events.emit(ADD_AD_UNITS);
events.emit(SET_TARGETING);
events.emit(BID_WON, bid);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants