Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug on adapterLoader not being loaded by babel #255

Closed
ialex opened this issue Mar 17, 2016 · 2 comments
Closed

Bug on adapterLoader not being loaded by babel #255

ialex opened this issue Mar 17, 2016 · 2 comments

Comments

@ialex
Copy link
Contributor

ialex commented Mar 17, 2016

The error below shows up on fresh clone, and fresh npm install trying to build prebid, i was able to build removing ES6 syntax on adapterLoader file

happens on OSX

gulp build
[23:05:48] Using gulpfile ~/Projects/PrebidGithub/gulpfile.js
[23:05:48] Starting 'clean'...
[23:05:48] Starting 'hint'...
[23:05:48] Starting 'jscs'...
[23:05:52] Starting 'webpack'...
[23:05:57] Starting 'devpack'...
[23:05:57] Finished 'clean' after 8.53 s
{ [Error: /Users/alex/Projects/PrebidGithub/loaders/adapterLoader.js:3
const fs = require('fs');
^^^^^
Use of const in strict mode.
@ multi main]
message: '/Users/alex/Projects/PrebidGithub/loaders/adapterLoader.js:3\nconst fs = require('fs');\n^^^^^\nUse of const in strict mode.\n @ multi main',
showStack: false,
showProperties: true,
plugin: 'webpack-stream',
__safety: { toString: [Function] } }
{ [Error: /Users/alex/Projects/PrebidGithub/loaders/adapterLoader.js:3
const fs = require('fs');
^^^^^
Use of const in strict mode.
@ multi main]
message: '/Users/alex/Projects/PrebidGithub/loaders/adapterLoader.js:3\nconst fs = require('fs');\n^^^^^\nUse of const in strict mode.\n @ multi main',
showStack: false,
showProperties: true,
plugin: 'webpack-stream',
__safety: { toString: [Function] } }
src/adapters/triplelift.js: line 1, col 5, 'CONSTANTS' is defined but never used.

1 error
[23:07:07] Finished 'jscs' after 1.3 min
[23:07:07] Finished 'hint' after 1.3 min
[23:07:07] Starting 'quality'...
[23:07:07] Finished 'quality' after 72 μs

@protonate
Copy link
Collaborator

What version of Node are you running? With the ES2015 syntax support we added a dependency of Node 4.x or greater, though this hasn't been well documented. An upgrade to Node should resolve this issue. More info is here.

This is also discussed in this issue.

@ialex
Copy link
Contributor Author

ialex commented Mar 17, 2016

node --version
v0.12.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants