Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate pbjs.setConfig({ cookieSyncDelay: 100 ) #3061

Closed
mkendall07 opened this issue Sep 7, 2018 · 1 comment
Closed

Deprecate pbjs.setConfig({ cookieSyncDelay: 100 ) #3061

mkendall07 opened this issue Sep 7, 2018 · 1 comment
Assignees
Labels
API Impact needs docs pinned won't be closed by stalebot

Comments

@mkendall07
Copy link
Member

mkendall07 commented Sep 7, 2018

Type of issue

Deprecation (API impact)

Description

We have 2 ways to set cookieSyncDelay.

  1. pbjs.setConfig({ cookieSyncDelay: 100 )
pbjs.setConfig({
    userSync: {
        syncDelay: 5000 // write image pixels 5 seconds after the auction
    }
});

We should remove option 1 since we have more configuration options now with the userSync object

@stale
Copy link

stale bot commented Sep 21, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2018
@stale stale bot closed this as completed Sep 28, 2018
@mkendall07 mkendall07 reopened this Sep 28, 2018
@stale stale bot removed the stale label Sep 28, 2018
@bwoolcott bwoolcott added the pinned won't be closed by stalebot label Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Impact needs docs pinned won't be closed by stalebot
Projects
None yet
Development

No branches or pull requests

3 participants