Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle size increased a lot in 1.27.0 #3174

Closed
felipemsantana opened this issue Oct 11, 2018 · 2 comments
Closed

Bundle size increased a lot in 1.27.0 #3174

felipemsantana opened this issue Oct 11, 2018 · 2 comments

Comments

@felipemsantana
Copy link

Type of issue

Bug

Description

From version 1.26.0 to 1.27.0 the bundle size increased by about 50%.
It was 126K and now it is 185K

Steps to reproduce

Enter in http://prebid.org/download.html
Select the following adapters/module

  • AOL
  • Appnexus
  • Criteo
  • Rubicon
  • Currency

Generate the bundle for versions 1.26.0 and 1.27.0, then compare the size.
@snapwich
Copy link
Collaborator

snapwich commented Oct 11, 2018 •
edited
Loading

It's most likely from the Criteo adapter and its additional RSA encryption added in 1.27 for "FastBid." It required the inclusion of some extra libraries: #3110

These libraries are only included in the Criteo adapter and shouldn't affect the size of the Prebid core files.

@bwoolcott
Copy link

#3169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@snapwich @mkendall07 @felipemsantana @bwoolcott