Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging not showing the prebid version at start #3700

Closed
belezebu opened this issue Apr 1, 2019 · 2 comments · Fixed by #3714 or #4007
Closed

Logging not showing the prebid version at start #3700

belezebu opened this issue Apr 1, 2019 · 2 comments · Fixed by #3714 or #4007
Assignees
Labels

Comments

@belezebu
Copy link

belezebu commented Apr 1, 2019

Type of issue

Bug

Description

After the Prebid version 2.0 the prebid version is not being logged at the beginning.

Steps to reproduce

Import the project as suggested in the example available in http://prebid.org/dev-docs/examples/basic-example.html
and notice that e.g.INFO: Prebid.js v2.8.0 loaded is not showing.

@jsnellbaker
Copy link
Collaborator

@snapwich Could you take a look into this issue? It seems to be indirectly caused by the changes to the hook implementation that was added during the 2.0 changeover.

During the utils.logInfo call for the prebid version, it gets to this line here. This call to config.setConfig goes to the hook package (looks like a setTrap()?), but never gets processed/executed later.

This stalled config update causes the subsequent return config.getConfig(...) to return a false, which prevents the log line from being written to the console.

The first logInfo call I see in the console is when we call pbjs.addAdUnits, which I believe happens because the hook.ready() has executed so everything is setup and any calls to config.setConfig get immediately processed.

Can you check to see if there may be something going wrong in the fun-hooks package? Or do we have to tweak the logic in prebid or move the logInfo call somewhere else?

@andyblackwell
Copy link
Contributor

The fix was reverted, so the problem still exists, can this be re-opened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants