-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter with labelAll or labelAny doesn't work for media type video #4135
Comments
@ethyde - in your expected results section you mention 'ad for the media type banner', but the title notes that the problem is in media type video. It makes sense that sizeConfig doesn't consider playersize - I suspect we never considered that scenario. But I think it should work for mediatype banner. |
Thanks for your answer, and sorry for delay. I have updated description and expected result. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hello, we have the same issue. |
This issue still exists, will create PR to fix it ;) |
closed by #9893 |
Type of issue
Bug
Description
When I am in the mediatype video, I want to filter the bidders configurations according to the device using the information of sizeConfig and labelAny or labelAll.
But that does not seem to apply
Steps to reproduce
labelAny: ["desktop"]
, and one with labelAny: ["phone"]Test page
there are some javascript errors but not related to this issue
https://jsfiddle.net/6zjpqxbf/
Expected results
For media type Video, bidders are filtered according to the labels.
Actual results
all bidders are send regardless of the labels
The text was updated successfully, but these errors were encountered: