Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter with labelAll or labelAny doesn't work for media type video #4135

Closed
ethyde opened this issue Aug 30, 2019 · 6 comments
Closed

Filter with labelAll or labelAny doesn't work for media type video #4135

ethyde opened this issue Aug 30, 2019 · 6 comments

Comments

@ethyde
Copy link

ethyde commented Aug 30, 2019

Type of issue

Bug

Description

When I am in the mediatype video, I want to filter the bidders configurations according to the device using the information of sizeConfig and labelAny or labelAll.

But that does not seem to apply

Steps to reproduce

  1. add a sizeConfig with desktop, tablet or mobile
  2. add 2 videos adunits, with 2 bidder config : one with labelAny: ["desktop"], and one with labelAny: ["phone"]
  3. load test page on any type of device, all bidder config are used

Test page

there are some javascript errors but not related to this issue
https://jsfiddle.net/6zjpqxbf/

Expected results

For media type Video, bidders are filtered according to the labels.

Actual results

all bidders are send regardless of the labels

@bretg
Copy link
Collaborator

bretg commented Sep 4, 2019

@ethyde - in your expected results section you mention 'ad for the media type banner', but the title notes that the problem is in media type video.

It makes sense that sizeConfig doesn't consider playersize - I suspect we never considered that scenario. But I think it should work for mediatype banner.

@ethyde
Copy link
Author

ethyde commented Sep 9, 2019

Thanks for your answer, and sorry for delay. I have updated description and expected result.

@stale
Copy link

stale bot commented Sep 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 23, 2019
@stale stale bot closed this as completed Sep 30, 2019
@bruceheller
Copy link

Hello, we have the same issue.

@ghost
Copy link

ghost commented Nov 17, 2022

This issue still exists, will create PR to fix it ;)

@patmmccann
Copy link
Collaborator

closed by #9893

@github-project-automation github-project-automation bot moved this from Ready for Dev to Done in Prebid.js Tactical Issues table May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants