Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpotX configuration since addition of videoCacheKey #4815

Closed
nanek opened this issue Feb 3, 2020 · 4 comments
Closed

SpotX configuration since addition of videoCacheKey #4815

nanek opened this issue Feb 3, 2020 · 4 comments
Labels

Comments

@nanek
Copy link
Contributor

nanek commented Feb 3, 2020

Type of issue

Question

Description

#4706 adds videoCacheKey to SpotX responses in Prebid 3.3.0. However this breaks rendering of SpotX instream without additional configuration. Can the SpotX docs be updated to indicate what the proper configuration should be? Specifically do we need to create custom GAM video creatives that specify a different VAST URL?

http://prebid.org/dev-docs/show-video-with-a-dfp-video-tag.html#notes-on-prebid-cache Notes If pbjs.setConfig({cache: {URL}}) is defined however I believe these docs are out of date and cache.url is always required since #1904.

I use

    cache: {
      url: 'https://prebid.adnxs.com/pbc/v1/cache',
    }

Lastly as I understand it videoCacheKey effectively overrides anything else based on #2143. http://prebid.org/dev-docs/show-video-with-a-dfp-video-tag.html#notes-on-prebid-cache indicate "In general, video-enabled bidders must supply bid.videoCacheKey, bid.vastXml, or bid.vastUrl on their responses, and can provide any combination of the three." However in practice, I don't think you can use the vastUrl if a videoCacheKey is provided. Please let me know if I've misunderstood this.

Thanks for any suggestions!

@lukacmi
Copy link

lukacmi commented Feb 6, 2020

@nanek I am not from SpotX, but you can resolve this by changing GAM creative to
https://search.spotxchange.com/ad/vast.html?key=%%PATTERN:hb_cache_id%%

This only applies to SpotX adapter due to #4706 change. Hope this helps.

@stale
Copy link

stale bot commented Feb 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 20, 2020
@stale stale bot closed this as completed Feb 27, 2020
@jarnix
Copy link
Contributor

jarnix commented Jun 12, 2020

Hi,
This forces to do a creative per bidder and it's a not easy to maintain. Did you find a better solution?

@nanek
Copy link
Contributor Author

nanek commented Jun 12, 2020

Agreed. I just revert #4706 in my custom build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants