Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all modules included in the prebid build in comments #6117

Closed
smenzer opened this issue Dec 11, 2020 · 3 comments
Closed

Include all modules included in the prebid build in comments #6117

smenzer opened this issue Dec 11, 2020 · 3 comments
Labels
help wanted pinned won't be closed by stalebot

Comments

@smenzer
Copy link
Collaborator

smenzer commented Dec 11, 2020

Type of issue

Feature Request

Description

When debugging publisher websites to see why something isn't working properly (for example, why GDPR consent strings are being picked up; or why an identity module is not providing IDs even though they're configured to), it's challenging to determine if it's simply because the module was not properly included during the build/download process.

I'd like to propose that we add comments to the top of the build that list the individual modules that were included in the build.

Steps to reproduce

Build prebid and look at the production version:
image

Expected results

From the example above, if we assume the build only included the pubmaticBidAdapter, userId, and id5IdSystem, then the comment at the top could look like this:

/* prebid.js v4.17.0
Updated : 2020-11-27 
Modules : pubmaticBidAdapter, userId, id5IdSystem */
!function(u){var s=window...

If we go this route, we should do the same for the Downloads page

Thoughts?

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 25, 2020
@pm-harshad-mane
Copy link
Contributor

Good suggestion.

@ChrisHuie
Copy link
Collaborator

#6297 merge closes out this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted pinned won't be closed by stalebot
Projects
None yet
Development

No branches or pull requests

4 participants