Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type checking on FirstPartyData #6346

Closed
pm-harshad-mane opened this issue Feb 23, 2021 · 1 comment
Closed

Type checking on FirstPartyData #6346

pm-harshad-mane opened this issue Feb 23, 2021 · 1 comment

Comments

@pm-harshad-mane
Copy link
Contributor

pm-harshad-mane commented Feb 23, 2021

Type of issue

Feature request

Description

As mentioned on https://docs.prebid.org/features/firstPartyData.html#how-bid-adapters-should-read-first-party-data

The Prebid First Party Data JSON structure reflects the OpenRTB standard. 
Arbitrary values should go in fpd.context.data or fpd.user.data. 
Fields that are meant to be standard OpenRTB 2.5 values should be in fpd.context or fpd.user. 
Specfically, the standard values for site are: name, domain, cat, sectioncat, pagecat, page, ref, search, keywords. 
For user these are: yob, gender, keywords.

FPD follows ORTB spec. Many bidders will like to add the type-checking logic on FPD before passing it to server side.
Rather than bidders implementing type-checking logic on their own can prebid-core add the same and eliminate type-mismatching fields before passing to bidders?

Also the doc suggests to put Arbitrary values in data like fpd.context.data or fpd.user.data, it will be great if prebid-core puts these fields in respective ext blocks like fpd.context.data.customKey is moved to fpd.context.ext.customKey, same for fpd.user.data.

Better if we standardize it before mass adoption.

@bretg
Copy link
Collaborator

bretg commented Feb 24, 2021

@pm-harshad-mane - this will be covered by the soon-to-be-developed First Party Data Module. #6099

We cannot afford to add non-essential bytes to core PBJS so type checking will be in a module for pubs who utilize FPD. Bidder endpoints will have to check anyhow, so pubs that don't implement the FPD module will get failures when data types are wrong.

@bretg bretg closed this as completed Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants