Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid Server renderer validation only checks adUnit.renderer #6792

Closed
muuki88 opened this issue May 19, 2021 · 3 comments
Closed

Prebid Server renderer validation only checks adUnit.renderer #6792

muuki88 opened this issue May 19, 2021 · 3 comments
Labels

Comments

@muuki88
Copy link
Collaborator

muuki88 commented May 19, 2021

Type of issue

Bug

Description

The validation in prebid server only checks for adUnit.renderer.

if (videoParams.context === 'outstream' && !adUnit.renderer) {

However it is possible to define a renderer on the mediaType property as described in the outstream docs.

Steps to reproduce

Define an ad slot with outstream context

pbjs.addAdUnit({
    code: 'video1',
    mediaTypes: {
        video: {
            context: 'outstream',
            playerSize: [640, 480],
            renderer: {
                url: 'example.com/videoRenderer.js',
                render: function (bid) { renderVideo(...)  }
            }
        }
    }
});

Configure prebid server integration.

Expected results

If only adUnit.mediaTypes.video.renderer is defined the request should be sent to prebid server

Actual results

If only adUnit.mediaTypes.video.renderer is defined the request is not sent to prebid server.

Platform details

  • Prebid.js 4.39.0
@patmmccann patmmccann added the bug label May 19, 2021
@patmmccann
Copy link
Collaborator

@muuki88 it seems like you know exactly what to write in the pr?

@muuki88
Copy link
Collaborator Author

muuki88 commented May 29, 2021

Hopefully 😁 Will open one once I'm back from vacation

@patmmccann
Copy link
Collaborator

Fixed on #6896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants