Losing user.data after getLegacyFpd

[nllerandi3lift]

Type of issue

Question / Possible bug

Description

user.data is getting dropped when the result of getConfig('ortb2') is passed into getLegacyFpd. A few bid adapters are still using this method so posting here first to see if this is desired behavior.

It looks like this may have been intentional at some point - #6293 (review)
As the method is filtering out data keys -

Prebid.js/src/config.js

Line 371 in 3fd3b5d

duplicate[prop] = (prop === 'context' || prop === 'user') ? Object.keys(obj[type]).filter(key => key !== 'data').reduce((result, key) => {

But user.data is an increasingly more relevant field - #6057

Is this intentional?

Steps to reproduce

Platform details

Testing on v6.19.0-pre, but I would think this some functionality can be found from when getLegacyFpd was introduced.

[patmmccann]

This appears to be a significant bug

[patmmccann]

@nllerandi3lift on further review, only very few adapters still use this function; perhaps you can deprecate your use of it?

[nllerandi3lift]

I figured that might be the case. The usage of fpd is pretty old at this point. I'll take a look at deprecating.

[nllerandi3lift]

We can close this if there are no other concerns. I'm fine with deprecating.

[bretg]

Thanks @nllerandi3lift - apparently we neglected to get rid of getLegacyFPD in 5, but will do so in 7.