-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting sendStandardTargetting to false does not suppress deal targets #827
Comments
the However, the @mkendall07 the |
We actually used an example where this is not set, as per the console:
The issue is that
|
I don't like how this is currently implemented. I think it would be better if we included How does that sound? |
That approach makes a lot of sense. In terms of the |
No, I don't consider them "standard" as it's not on by default (you need to set/call I would, however, consider using both of these settings at the same time to be invalid: Is there a use case when you are doing that? |
Also, as an aside, do you know what the difference is here?
My understanding is that GPT is the URL generated on page (which contains key/value pairs) and URLS generated by ad serving would be any further URLs generated from the creative... but not 100%. |
I think this sounds ideal. |
The GPT docs have been recently changed, but it's not entirely clear what the difference is. That being said, the extra key length can still contribute to either limit.
Fair enough -- but there does not appear to be any option to suppress the deal targets if
I would assume that pubs might simply turn on |
Type of issue
Bug
Description
Following the prebid documentation, when setting
sendStandardTargetting
tofalse
and adding in custom target names usingadserverTargeting
, the only expected targets should be the custom targets. However, if the bid has deal targets, the standard deal targets will not be suppressed. The custom targets will be set as well; however, the intended behaviour is not observed as the deal targets remain.Steps to reproduce
When returning deal bids for a slot, the following behaviour was observed for the targeting:
Expected results
Expected Targets:
Actual results
Unexpected Targets:
Platform details
Versions 0.14+ are affected.
The text was updated successfully, but these errors were encountered: