-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new param in refererDetection to get top most referer #8294
Comments
In what situation does it make sense to get the referrer to an iframe? isn't this just a bug with the current referrer detection? Also related: #5637 |
Dug a little more, and I think this is a bug that has become a feature. In the simple case where Prebid is not running in a cross-origin iframe, the Prebid.js/src/refererDetection.js Line 148 in 32f4a5c
There's no attempt to grab the actual referer as we do for iframes: Prebid.js/src/refererDetection.js Line 127 in 32f4a5c
adapters are relying on this behavior - made especially clear by code that effectively says "get the current location from refererInfo, but don't expect it to contain the referrer": Prebid.js/modules/gmosspBidAdapter.js Lines 172 to 190 in 32f4a5c
I'll try to address this with a breaking change for prebid 7 (#5637), but I'm not sure what we can do for 6 - I think most adapters are getting the wrong values if Prebid is running in an iframe. |
tracking on #5637 |
Type of issue
Feature request
Description
Some adapters are implementing their own functions to get the top most referer.
See here for details and example: #8261
We should add this into the referer object passed into bid adapters so they do not have to duplicate this code!
The text was updated successfully, but these errors were encountered: