-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate Dual render ad paths #8358
Comments
I think the first path is for SafeFrames and the second is for non-safe frames. I'm not 100% sure one is compatible in the the environment of the other. I would agree with the desire to remove the "GLOBAL" path though. |
patmmccann
moved this from Needs Req
to Ready for Dev
in Prebid.js Tactical Issues table
Jan 30, 2023
It's unclear to me how we should deal with some of the differences:
|
2 tasks
dgirardi
moved this from Ready for Dev
to PR submitted
in Prebid.js Tactical Issues table
Mar 13, 2023
github-project-automation
bot
moved this from PR submitted
to Done
in Prebid.js Tactical Issues table
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Type of issue
Two areas of the code base can render an ad
Prebid.js/src/secureCreatives.js
Line 56 in 880b089
and
Prebid.js/src/prebid.js
Line 447 in 2d14b7d
We've had various problems with these getting out of sync, including #7702 and potentially recording analytics events eg bid_won.
It seems best if we consolidate them, potentially by removing the latter and always forcing the post message into an iframe with the creative in it.
The text was updated successfully, but these errors were encountered: