-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Price Floors module rejects valid bids ? #8565
Comments
I do not see a screenshot in the OP - it would help to get an example of a bid you believe should not have been rejected together with your prebid configuration. Trying on that website I saw this - does it qualify? in that particular case the You should be able to set floors on unadjusted CPMs with the |
Starting to look into and work on this ticket today |
Hi @dgirardi indeed that an example of rejected bids I see and where I don't understand why they are considering their cpm is higher than the floor value. |
@matthieularere-msq because the CPM is being adjusted lower by your (or your colleagues') |
Should the |
Indeed it should - and I missed that - it looks like it may be adjusted twice. Looking into this. |
So, there are some quirks that make it confusing - but I believe the likely explanation is still that The logic works like this: when a bid comes back from the backend, first it's passed through the currency module (priority 100), then the floors module (priority 50). At the end, just before it gets finally added to the auction, I believe what happens is:
So the I'll see if I can get another one of those bids from the website in the OP to conclusively say this is the case - if it is, I don't think it's great, but I'm not sure how to "fix" it - my instinct is that a single |
@robertrmartinez could you weigh in? Do you think this can be addressed straightforwardly? |
Would it help if we added a sort of history log for changes to the CPM? Let's say a "normal" (non-rejected) bid contained something like:
then this case would only contain the first and it should clear up confusion. (although, I'd still be wondering why my |
Agree with @dgirardi. From what I can gather about all of this (and from looking through the prebid docs), it seems as though the expected behavior is occurring (I think). However, I suppose the timeline of the cpm value adjustments could possibly be made a bit more transparent as mentioned above. |
So what is the Action Item here? |
perhaps we just need more explicit logging of rejected bids? |
In my initial P.O.C of this I actually was just going to add a new event called I decided not to do it for some reason, but I think this is probably the right thing to do now. Maybe in the case of a But that might be a breaking change, so maybe for now we can just add in this new |
@robertrmartinez for this issue specifically, I don't think an a different event would have helped - I think; the log message would have beeen the same, showing the rejected bid with a half-adjusted cpm (I believe it would have looked the same in a rejection event, unless we want to open pandora's box and try to process those together with "real" bids?) |
Ah ok makes sense! |
Type of issue
bug
Description
In prebid's console log lines I can see bid which are rejected by the price floor module but as far as I understand they are valid bids. For example see attached screenshot, where floorValue 0.25 is set in currency EUR, a 0.2886 USD bid is received, converted to 0.2761 EUR but is rejected.
Steps to reproduce
I noticed this behavior on this page https://www.marmiton.org/?pbjs_debug=true after a few refreshs.
Is there something I missed with the reason why this bid was rejected ?
Thanks.
The text was updated successfully, but these errors were encountered: