Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent adapter and alias codes in auctionEnd events #8568

Closed
patmmccann opened this issue Jun 15, 2022 · 9 comments
Closed

Transparent adapter and alias codes in auctionEnd events #8568

patmmccann opened this issue Jun 15, 2022 · 9 comments
Assignees

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Jun 15, 2022

Type of issue

Feature request

Description

Third party entities using the prebid public apis eg browser extensions, publisher analytics tools, debuggers, web scrapers, and rendering libraries may often wish to know all three of the response bidder code, the adapter code, and the adapter code the adapter was aliased from. We should provide a way for these other entities to delineate all three in the auctionEnd event. One possibility is to put them in a vector where bidderCode would be of length one for normal requests, but up to length 3. Another possiblity is to bidderCode, adapterCode, origAdapterCode places in object structure.

One alternative is we could make adapterRegistry accessible via api?

related

#8129

@patmmccann patmmccann changed the title Transparent adapter codes in bid responses Transparent adapter and alias codes in bid responses Jun 15, 2022
@patmmccann patmmccann changed the title Transparent adapter and alias codes in bid responses Transparent adapter and alias codes in auctionEnd events Jun 15, 2022
@patmmccann
Copy link
Collaborator Author

patmmccann commented Jun 15, 2022

Perhaps this could be of length 4 if the publisher aliases a known alias, eg suppose bidder code in the response is 'someentity' which is an alternative bidder code for 'tx' which is a configured alias of 'trustx' which is a known alias of 'grid' ? If so, the vector of codes approach seems preferable to the named slot 'original_original_code'

@dgirardi
Copy link
Collaborator

I'm curious about why / how this would with auctionEnd? those three are properties of each bid - and adapterCode is already available. Only the alias resolution is missing.

Currently it's possible to do

pbjs.onEvent('bidResponse', (bid) => {
   const {bidderCode, adapterCode} = bid;
})
pbjs.onEvent('auctionEnd', (auction) => {
   auction.bidsReceived.map(({bidderCode, adapterCode}) => ...)
   auction.winningBids.map(({bidderCode, adapterCode}) => ...)
})

is this about adding the alias resolution, or changing the arguments to the auctionEnd event?

@patmmccann
Copy link
Collaborator Author

This is about adding the alias resolution, correct

@patmmccann
Copy link
Collaborator Author

On further inspection, analytics adapters already have this info, eg

function getAdapterNameForAlias(aliasName) {

@patmmccann
Copy link
Collaborator Author

result of committee discussion is we plan to make adapterRegistry accessible via api; allow publishers to suppress this public api via configuration

@jlquaccia
Copy link
Collaborator

Hey @patmmccann, I was thinking of taking this gh issue on next. To clarify, it sounds like the req's for this ticket would be something like the following (let me know if im off, which i might be):

@patmmccann
Copy link
Collaborator Author

@jlquaccia I think it is much simpler than that; I think we might just need to make the existing aliasRegistry public? The auctionEnd event seemed to be an alternative to it being public and committee discussion seemed to favor not messing with auctionEnd.

@patmmccann
Copy link
Collaborator Author

Very excited you might take this one on, thanks!

@jlquaccia
Copy link
Collaborator

@patmmccann ah, ok gotcha, that does sounds a bit more simple! Will create a new PR shortly around this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants