Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep set dependency upgrade #8972

Closed
patmmccann opened this issue Sep 8, 2022 · 0 comments · Fixed by #8443
Closed

Deep set dependency upgrade #8972

patmmccann opened this issue Sep 8, 2022 · 0 comments · Fixed by #8443
Assignees
@patmmccann
Labels
dependencies Pull requests that update a dependency file

Comments

@patmmccann
Copy link
Collaborator

Type of issue

Deep set upgrade fails on https://github.com/prebid/Prebid.js/pull/8443/files

Chrome 104.0.5112.81 (Windows 10) ERROR
Uncaught TypeError: (0 , _utils.deepSetValue) is not a function
at /tmp/_karma_webpack_106025/commons.js:37328:980

Dset 3 has some useful features ( eg lukeed/dset#12 ) as well as some security improvement
@patmmccann patmmccann moved this from Triage to Ready for Dev in Prebid.js Tactical Issues table Sep 8, 2022
@patmmccann patmmccann linked a pull request Sep 8, 2022 that will close this issue
Prebid Core: Upgrade deepSetValue import #8443
Merged
@patmmccann patmmccann self-assigned this Sep 8, 2022
@patmmccann patmmccann added the dependencies Pull requests that update a dependency file label Sep 8, 2022
@patmmccann patmmccann moved this from Ready for Dev to PR submitted in Prebid.js Tactical Issues table Sep 8, 2022
Repository owner moved this from PR submitted to Done in Prebid.js Tactical Issues table Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patmmccann patmmccann

Labels
dependencies Pull requests that update a dependency file
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prebid Core: Upgrade deepSetValue import prebid/Prebid.js
1 participant
@patmmccann