Appnexus Adapter: bug during conversion of ortb2 keyword strings to object format

[anitaschiller]

Type of issue

Bug

Description

When loading ads, the browser console shows an error in the Appnexus adapter with the information that string.split() cannot be used on undefined.

I think this is caused by ortb2ImpKwStr being undefined (see screenshot below).

Prebid.js/modules/appnexusBidAdapter.js

Lines 785 to 788 in c4605d5

	let ortb2ImpKwStr = deepAccess(bid, 'ortb2Imp.ext.data.keywords');
	if ((isStr(ortb2ImpKwStr) && ortb2ImpKwStr !== '') || !isEmpty(bid.params.keywords)) {
	// convert ortb2 from comma list string format to bid param object format
	let ortb2ImpKwObj = convertStringToKeywordsObj(ortb2ImpKwStr);

The function convertStringToKeywordsObj still gets called and split() is trying to be used on keyStr which is undefined.

Prebid.js/modules/appnexusBidAdapter.js

Lines 1202 to 1206 in c4605d5

	function convertStringToKeywordsObj(keyStr) {
	let result = {};
	// will split based on commas and will eat white space before/after the comma
	let keywordList = keyStr.split(/\s*(?:,)\s*/);

Screenshot

Platform details

Prebid.js version 7.15

Other information

Probably connected to this PR.

[jsnellbaker]

@anitaschiller Thank you for reporting and investigating this issue. I have put together a fix for this scenario (see above). It should hopefully be merged soon.

[muuki88]

The bug is triggered if you set params.keywords , but not in ortb2Imp.ext.data.keywords .

[jsnellbaker]

The issue was within the new function that was designed to help transform the structure of the ortb keywords; it unfortunately didn't properly handle an undefined state that came when you only had bid param keywords present.