Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid and MGID bid adapters missing gvlid spec #9121

Closed
bretg opened this issue Oct 17, 2022 · 1 comment · Fixed by #9124
Closed

Grid and MGID bid adapters missing gvlid spec #9121

bretg opened this issue Oct 17, 2022 · 1 comment · Fixed by #9124
Labels

Comments

@bretg
Copy link
Collaborator

bretg commented Oct 17, 2022

Type of issue

Bug

Description

We discovered that the client-side Grid bid adapter is being rejected by the GDPR enforcement module because it doesn't specify the gvlid in the correct location. Did a scan of all the adapters and found the mgid adapter has a similar issue. Both define GVLID as a const, but then never actually set that const in the spec:

gridBidAdapter.js:const GVLID = 686;
mgidBidAdapter.js:const GVLID = 358;

Here's how it's supposed to look:

export const spec = {
  code: 'myBidderCode',
  gvlid: GVLID,

Tagging @TheMediaGrid and @Gaudeamus

@bretg bretg added the bug label Oct 17, 2022
@bretg
Copy link
Collaborator Author

bretg commented Oct 17, 2022

FWIW, there is a workaround - publishers who want to use these adapters can set their own mapping:

pbjs.setConfig({
    gvlMapping: {
        grid: 686,
        mgid: 358
    }
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

1 participant