AdForm adapter: result bid missing bidId from _bidsRequested

[PsychodelEKS]

Type of issue

bug

Description

AdForm adapter served bids (passed to bidsBackHandler) do not have any attribute to match them with bids from _bidsRequested.

Steps to reproduce

1. Configure adform adapter to bid any placement
2. register any fucntion as a bidsBackHandler to observe passed results
3. get bid from adform

Expected results

adform bid contains adId which matches bidId from corresponding requsted bid (_bidsRequested)

Actual results

there is adId, but it does not match _bidsRequested[*].bidId

Platform details

independant

Other information

Made a hack myself, though there may be better solution (I used additional attribute requestBidId not to interfere with anything):

@@ -78,12 +78,14 @@ function AdformAdapter() {
           bidObject.width = adItem.width;
           bidObject.height = adItem.height;
           bidObject.dealId = adItem.deal_id;
-          bidmanager.addBidResponse(bid.placementCode, bidObject);
         } else {
           bidObject = bidfactory.createBid(2);
           bidObject.bidderCode = bidder;
-          bidmanager.addBidResponse(bid.placementCode, bidObject);
         }
+
+        bidObject.requestBidId = bid.bidId;
+
+        bidmanager.addBidResponse(bid.placementCode, bidObject);
       }
     };

[mkendall07]

@prebid/adform
Can you please check?

[matthewlane]

#947 to match Adform bids has been merged into master