Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates needed for integrationExamples/gpt/x-domain/creative.js #954

Closed
brondsem opened this issue Jan 25, 2017 · 2 comments
Closed

Updates needed for integrationExamples/gpt/x-domain/creative.js #954

brondsem opened this issue Jan 25, 2017 · 2 comments
Assignees

Comments

@brondsem
Copy link
Contributor

Type of issue

Bug

Description

  • the JSON.stringify call has a dangling adServerDomain all by itself
  • In IE, the ad doesn't render and console has this error: SEC7111: HTTPS security is compromised by (null) https://tpc.googlesyndication.com/safeframe/1-0-5/html/container.html
  • In IE < 11, const raises a syntax error, var should be used instead.
  • The id var isn't defined anywhere
  • Per Mobile Auto Redirect Ads - Increasing Major PROBLEM. #927 (comment) adServerDomain should check the current protocol (or just default to https)
  • Instead of %%PUBLISHER_DOMAIN%%, %%PATTERN:url%% exists already and can be parsed to get the domain.
  • would be nice to have <script>....</script> around the whole JS (and then save the file as .html) so it is a full example ready to paste directly in.

I can provide a merge request shortly for most of these items, but I don't know how to fix the IE HTTPS error.

@brondsem
Copy link
Contributor Author

http://joji.me/en-us/blog/how-to-resolve-sec7111-https-security-is-compromised-by-null-error-in-ie11 indicates its the doc.write calls that IE doesn't like.

@brondsem
Copy link
Contributor Author

brondsem commented Feb 9, 2017

Fixed with #955 and #971

@brondsem brondsem closed this as completed Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants