New Video module MediaTypes:{ Video { , wont take values

[spormeon]

The new video module doesnt seem to take multiple values in the mediaTypes{ video. Its only sending the first value

when i have multiple value set in some:
playbackmethod: [2, 6],
protocols: [1, 2, 3, 4, 5, 6, 7, 8]
api: [1, 2, 3, 4, 5, 6],

there also seems to be some "constants" such as mimes, boxingallowed, playbackend

I presume its @karimMourra that will look?

[spormeon]

I can see where these are coming from now, the videojs module": videojsVideoProvidor.js, its setting them there but shouldnt we be allowed to override these in the usual "prebid way" of anything we put in the prebid scripts direct in the mediaTypes{ video { ,takes precedent. Gives a harmony across all banner, native, video etc then?

using something such as: class="vjs-big-play-centered vjs-fluid" for if you want to "dynamically" fill width, height creates all sorts of problems as the playerSize pulls from the video width="640" height="480" in videojs

[spormeon]

videojs mdule, is also missing the ability to set the ima options such as:enableOmidBeta: true,
preventLateAdStart: false,
disableFlashAds: true,
prerollTimeout: 18000,
autoPlayAdBreaks: true,
vastLoadTimeout: 8000,
numRedirects: 6,
disableCustomPlaybackForIOS10Plus: true,
vpaidMode: 'ENABLED',
cookiesEnabled: true,

setting in the adPluginConfig: {} does nothing:

[karimMourra]

Hi @spormeon if i understand correctly, you are reporting 2 issues:

1. the video params reported by the video player submodule are overriding the publisher's settings
2. Params passed in the adPluginConfig for video.js are not being applied.

Please let me know if this is correct, in the meantime I will investigate, thanks!

[karimMourra]

Hey @spormeon I am making changes so that existing video params defined by the publisher take precedence, but I must point out that the idea of having the videojs submodule define the params comes from the fact that the videojs submodule should be the source of truth for everything video.js related. In the case for example of playback method, if the video.js instance is configured to autostart, then i think the value should only be 1. I think it would be misleading for it to include other values like 3 (click-to-play).
The idea of this is to make it easier for publishers, since they no longer have to worry about the values being set, they can trust that the video.js submodule will set the accurate values, and at the same time SSPs can trust that the values are accurate because they come from the video player which is the source of truth.
If the video.js submodule is wrong, then that is a bug needed to be fixed in the submodule.

[karimMourra]

@spormeon regarding the IMA configuration, i don't see some of those params in the doc https://github.com/googleads/videojs-ima, are you sure they are supported ?
In your test environment, if you add a breakpoint at the following line https://github.com/prebid/Prebid.js/blob/master/modules/videojsVideoProvider.js#L525, could you please confirm that the object is as expected ?

[spormeon]

To reply 1. Yes, to reply 2. Yes. On ima settings there all in additional settings on videojs Ima GitHub. As there are settings for contrib ads and ima settings it's not clear what adPluginSettings will actually set, one of, both of but non work at moment . I'll try line 525 but I'm away in Poland at mo, not back until next week

[spormeon]

@karimMourra I've tried these ima options in following but def dont work. i.e you can see the adLabel: 'Ad' is not set, these are pretty much all the videojs ima "options"
adPluginConfig: {
debug: true,
ppid: true,
enableOmidBeta: true,
preventLateAdStart: false,
disableFlashAds: true,
prerollTimeout: 10000,
autoPlayAdBreaks: true,
vastLoadTimeout: 8000,
numRedirects: 8,
disableCustomPlaybackForIOS10Plus: true,
vpaidMode: 'ENABLED',
cookiesEnabled: true,
adLabel: 'Ad',
AdsRenderingSettings: {
autoAlign: false,
bitrate: 1800,
useStyledNonLinearAds: true,
},
omidVendorAccess: {
OmidAccessMode: 'FULL',
OmidVerificationVendor: 'OTHER'
},
contribAdsSettings: {
timeout: 5000,
prerollTimeout: 10000,
allowVjsAutoplay: true,
debug: true
},
},
vendorConfig: {

[spormeon]

update, seems to now work in prebid V 7.39.0, so all good on IMA "options" & contrib Ads options by looks