-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow NPM to access private methods #9723
Comments
perhaps cut for time ? tbd, to discuss with pubs? |
@JulieLorin @khatibda @muuki88 do you have projects that import prebid as an npm? can you provide any feedback here? |
We use Prebid as an NPM dependency and only use the All other access happens through public APIs. |
We use Prebid as an NPM dependency, but we are using more than just the processQueue function. I think allowing prebid to be used as a library is useful to be able to use only some parts of prebid.js but not all of them (for example, being able to manage instream without needing a prebid-cache compatible endpoint). |
we're also using the |
Using Prebid as a dependency allows access to private methods such as
gdprDataHandler
in this case #9333 (comment). Proposal to no longer allow this behavior in Prebid 8. Still reviewing the bandwidth that would be needed for this issue.The text was updated successfully, but these errors were encountered: