Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdLoox Ad Server: Flaky test #9776

Closed
patmmccann opened this issue Apr 6, 2023 · 4 comments · Fixed by #9881
Closed

AdLoox Ad Server: Flaky test #9776

patmmccann opened this issue Apr 6, 2023 · 4 comments · Fixed by #9881
Assignees
@dgirardi
Labels
bug

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Apr 6, 2023 •
edited
Loading

Many pr's failing to pass circle ci; main issue appears to be an AdLoox ad server test

https://app.circleci.com/pipelines/github/prebid/Prebid.js/15291/workflows/a8f83393-c655-41f4-8ed2-25edfcf6bc87/jobs/27920

Prebid.js/test/spec/modules/adlooxAdServerVideo_spec.js

Line 257 in 81fd111

xfr.addFilter(x => true); // there is no network traffic for Blob URLs here
claims there is no network traffic; than why are there so many time out issues? @jimdigriz would love your feedback
@patmmccann patmmccann added the bug label Apr 6, 2023
@patmmccann patmmccann moved this from Triage to Ready for Dev in Prebid.js Tactical Issues table Apr 6, 2023
@jimdigriz
Copy link
Contributor

My guess is something went wrong with the ajax.js catch block; my original fix or the IE11 edge case may not be correct or good enough.

Does this only impact a single browser (this one shows Edge)? Maybe XHR does something crazy on Edge for expired Blob URLs like it did for IE11?

@jimdigriz
Copy link
Contributor

jimdigriz commented Apr 6, 2023 •
edited
Loading

Looks to again be Edge for #9728 (comment)

@patmmccann
Copy link
Collaborator Author

You're right, appears to always be edge https://app.circleci.com/pipelines/github/prebid/Prebid.js/15343/workflows/0fda394f-e7ca-476f-9cd7-4011452a1a42/jobs/28001

@patmmccann
Copy link
Collaborator Author

Bumping edge 111-> 112 appears to have solved

@github-project-automation github-project-automation bot moved this from Ready for Dev to Done in Prebid.js Tactical Issues table Apr 13, 2023
@patmmccann patmmccann reopened this May 1, 2023
@patmmccann patmmccann moved this from Open to PR submitted in Prebid.js Tactical Issues table May 1, 2023
@patmmccann patmmccann linked a pull request May 1, 2023 that will close this issue
Adloox server video: mock out blob URLs in tests #9881
Merged
1 task
@github-project-automation github-project-automation bot moved this from PR submitted to Done in Prebid.js Tactical Issues table May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgirardi dgirardi

Labels
bug
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adloox server video: mock out blob URLs in tests dgirardi/Prebid.js
3 participants
@patmmccann @jimdigriz @dgirardi