Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triplelift Bid Adapter: stop override on placement #10408

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

patmmccann
Copy link
Collaborator

fixes #10407

@nllerandi3lift
Copy link
Contributor

Is this necessary even with placement:1 being the only true instream value? Is not context:'instream', placement:2 (or any other value) just wrong? Otherwise I see no harm here, but thought I'd fire this Q off first.

@patmmccann
Copy link
Collaborator Author

Some publishers have been instructed by DSPs that they must set video.placement equal to a value other than one when they have muted pre-roll. In this case video.context will remain 'instream' even though video.placement has some other value.

@patmmccann patmmccann merged commit 5ef3a17 into master Aug 29, 2023
2 checks passed
@patmmccann patmmccann deleted the tripplcmntbug branch August 29, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Triplelift bid adapter: overrides publisher selections
3 participants