From 6d9b63e6d827f333ee6dcb4b93713cf70066a5d7 Mon Sep 17 00:00:00 2001
From: Konstantin Korobkov <kostya-kor@yandex-team.ru>
Date: Thu, 14 Dec 2023 17:04:14 +0100
Subject: [PATCH 1/2] Add rtt (roud trip time) tracking via nurl in
 yandexBidAdapter

---
 modules/yandexBidAdapter.js                | 22 ++++++++-
 test/spec/modules/yandexBidAdapter_spec.js | 55 ++++++++++++++++++++--
 2 files changed, 73 insertions(+), 4 deletions(-)

diff --git a/modules/yandexBidAdapter.js b/modules/yandexBidAdapter.js
index 2a306acdcf0..f86411f0a61 100644
--- a/modules/yandexBidAdapter.js
+++ b/modules/yandexBidAdapter.js
@@ -140,7 +140,7 @@ export const spec = {
   interpretResponse: interpretResponse,
 
   onBidWon: function (bid) {
-    const nurl = bid['nurl'];
+    const nurl = addRTT(bid['nurl'], bid.timeToRespond);
 
     if (!nurl) {
       return;
@@ -378,4 +378,24 @@ function replaceAuctionPrice(url, price, currency) {
     .replace(/\${AUCTION_CURRENCY}/, currency);
 }
 
+function addRTT(url, rtt) {
+  if (!url) return;
+
+  if (url.indexOf(`\${RTT}`) > -1) {
+    return url.replace(/\${RTT}/, rtt ?? -1);
+  }
+
+  let urlObj = new URL(url);
+
+  if (Number.isInteger(rtt)) {
+    urlObj.searchParams.set('rtt', rtt);
+  } else {
+    urlObj.searchParams.delete('rtt');
+  }
+
+  url = urlObj.toString();
+
+  return url;
+}
+
 registerBidder(spec);
diff --git a/test/spec/modules/yandexBidAdapter_spec.js b/test/spec/modules/yandexBidAdapter_spec.js
index eef476e21d2..101fb59f234 100644
--- a/test/spec/modules/yandexBidAdapter_spec.js
+++ b/test/spec/modules/yandexBidAdapter_spec.js
@@ -1,6 +1,6 @@
 import { assert, expect } from 'chai';
 import { spec, NATIVE_ASSETS } from 'modules/yandexBidAdapter.js';
-import { parseUrl } from 'src/utils.js';
+import * as utils from 'src/utils.js';
 import { BANNER, NATIVE } from '../../../src/mediaTypes';
 import { config } from '../../../src/config';
 
@@ -71,7 +71,7 @@ describe('Yandex adapter', function () {
 
       expect(method).to.equal('POST');
 
-      const parsedRequestUrl = parseUrl(url);
+      const parsedRequestUrl = utils.parseUrl(url);
       const { search: query } = parsedRequestUrl
 
       expect(parsedRequestUrl.hostname).to.equal('bs.yandex.ru');
@@ -100,7 +100,7 @@ describe('Yandex adapter', function () {
       const bannerRequest = getBidRequest();
       const requests = spec.buildRequests([bannerRequest], bidderRequest);
       const { url } = requests[0];
-      const parsedRequestUrl = parseUrl(url);
+      const parsedRequestUrl = utils.parseUrl(url);
       const { search: query } = parsedRequestUrl
 
       expect(query['ssp-cur']).to.equal('USD');
@@ -443,6 +443,55 @@ describe('Yandex adapter', function () {
       });
     });
   });
+
+  describe('onBidWon', function() {
+    beforeEach(function() {
+      sinon.stub(utils, 'triggerPixel');
+    });
+    afterEach(function() {
+      utils.triggerPixel.restore();
+    });
+
+    it('Should not trigger pixel if bid does not contain nurl', function() {
+      const result = spec.onBidWon({});
+      expect(utils.triggerPixel.callCount).to.equal(0)
+    })
+
+    it('Should trigger pixel if bid has nurl', function() {
+      const result = spec.onBidWon({
+        nurl: 'https://example.com/some-tracker',
+        timeToRespond: 378,
+      });
+      expect(utils.triggerPixel.callCount).to.equal(1)
+      expect(utils.triggerPixel.getCall(0).args[0]).to.equal('https://example.com/some-tracker?rtt=378')
+    })
+
+    it('Should trigger pixel if bid has nurl with path & params', function() {
+      const result = spec.onBidWon({
+        nurl: 'https://example.com/some-tracker/abcdxyz?param1=1&param2=2',
+        timeToRespond: 378,
+      });
+      expect(utils.triggerPixel.callCount).to.equal(1)
+      expect(utils.triggerPixel.getCall(0).args[0]).to.equal('https://example.com/some-tracker/abcdxyz?param1=1&param2=2&rtt=378')
+    })
+
+    it('Should trigger pixel if bid has nurl with path & params and rtt macros', function() {
+      const result = spec.onBidWon({
+        nurl: 'https://example.com/some-tracker/abcdxyz?param1=1&param2=2&custom-rtt=${RTT}',
+        timeToRespond: 378,
+      });
+      expect(utils.triggerPixel.callCount).to.equal(1)
+      expect(utils.triggerPixel.getCall(0).args[0]).to.equal('https://example.com/some-tracker/abcdxyz?param1=1&param2=2&custom-rtt=378')
+    })
+
+    it('Should trigger pixel if bid has nurl and there is no timeToRespond param, but has rtt macros in nurl', function() {
+      const result = spec.onBidWon({
+        nurl: 'https://example.com/some-tracker/abcdxyz?param1=1&param2=2&custom-rtt=${RTT}',
+      });
+      expect(utils.triggerPixel.callCount).to.equal(1)
+      expect(utils.triggerPixel.getCall(0).args[0]).to.equal('https://example.com/some-tracker/abcdxyz?param1=1&param2=2&custom-rtt=-1')
+    })
+  })
 });
 
 function getBidConfig() {

From efb22ac55c1399566d07c526c6486b22b5d85443 Mon Sep 17 00:00:00 2001
From: Konstantin Korobkov <kostya-kor@yandex-team.ru>
Date: Thu, 21 Dec 2023 10:44:38 +0100
Subject: [PATCH 2/2] Yandex Bid Adapter: Fix let -> const

---
 modules/yandexBidAdapter.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/yandexBidAdapter.js b/modules/yandexBidAdapter.js
index f86411f0a61..c427d021151 100644
--- a/modules/yandexBidAdapter.js
+++ b/modules/yandexBidAdapter.js
@@ -385,7 +385,7 @@ function addRTT(url, rtt) {
     return url.replace(/\${RTT}/, rtt ?? -1);
   }
 
-  let urlObj = new URL(url);
+  const urlObj = new URL(url);
 
   if (Number.isInteger(rtt)) {
     urlObj.searchParams.set('rtt', rtt);