From 502ba2ae4d6dd0c733472351ec44062c3cbce3d2 Mon Sep 17 00:00:00 2001 From: yubei01 Date: Fri, 19 Jan 2024 19:02:01 +0800 Subject: [PATCH 1/5] feat(isBidRequestValid): just filter token once. not filter publisher and tagid --- modules/discoveryBidAdapter.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/discoveryBidAdapter.js b/modules/discoveryBidAdapter.js index 551c78c1e24..1576a8dcb08 100644 --- a/modules/discoveryBidAdapter.js +++ b/modules/discoveryBidAdapter.js @@ -511,7 +511,7 @@ export const spec = { if (bid.params.badv) { globals['badv'] = Array.isArray(bid.params.badv) ? bid.params.badv : []; } - return !!(bid.params.token && bid.params.publisher && bid.params.tagid); + return true; }, /** @@ -522,6 +522,8 @@ export const spec = { * @return ServerRequest Info describing the request to the server. */ buildRequests: function (validBidRequests, bidderRequest) { + if (!globals['token']) return; + let payload = getParam(validBidRequests, bidderRequest); const payloadString = JSON.stringify(payload); From 5314ec3888972e05b5a60ff3ec70eeac68901970 Mon Sep 17 00:00:00 2001 From: yubei01 Date: Fri, 19 Jan 2024 19:11:55 +0800 Subject: [PATCH 2/5] feat(isBidRequestValid): add unit test --- test/spec/modules/discoveryBidAdapter_spec.js | 87 +++++++++++++++++++ 1 file changed, 87 insertions(+) diff --git a/test/spec/modules/discoveryBidAdapter_spec.js b/test/spec/modules/discoveryBidAdapter_spec.js index 05216ff126c..82825d37f63 100644 --- a/test/spec/modules/discoveryBidAdapter_spec.js +++ b/test/spec/modules/discoveryBidAdapter_spec.js @@ -80,6 +80,77 @@ describe('discovery:BidAdapterTests', function () { }; let request = []; + let bidRequestDataNoParams = { + bidderCode: 'discovery', + auctionId: 'ff66e39e-4075-4d18-9854-56fde9b879ac', + bidderRequestId: '4fec04e87ad785', + bids: [ + { + bidder: 'discovery', + params: { + referrer: 'https://discovery.popin.cc', + }, + refererInfo: { + page: 'https://discovery.popin.cc', + stack: [ + 'a.com', + 'b.com' + ] + }, + mediaTypes: { + banner: { + sizes: [[300, 250]], + pos: 'left', + }, + }, + ortb2: { + user: { + ext: { + data: { + CxSegments: [] + } + } + }, + site: { + domain: 'discovery.popin.cc', + publisher: { + domain: 'discovery.popin.cc' + }, + page: 'https://discovery.popin.cc', + cat: ['IAB-19', 'IAB-20'], + }, + }, + ortb2Imp: { + ext: { + gpid: 'adslot_gpid', + tid: 'tid_01', + data: { + browsi: { + browsiViewability: 'NA', + }, + adserver: { + name: 'adserver_name', + adslot: 'adslot_name', + }, + keywords: ['travel', 'sport'], + pbadslot: '202309999' + } + } + }, + adUnitCode: 'regular_iframe', + transactionId: 'd163f9e2-7ecd-4c2c-a3bd-28ceb52a60ee', + sizes: [[300, 250]], + bidId: '276092a19e05eb', + bidderRequestId: '1fadae168708b', + auctionId: 'ff66e39e-4075-4d18-9854-56fde9b879ac', + src: 'client', + bidRequestsCount: 1, + bidderRequestsCount: 1, + bidderWinsCount: 0, + }, + ], + }; + it('discovery:validate_pub_params', function () { expect( spec.isBidRequestValid({ @@ -93,12 +164,28 @@ describe('discovery:BidAdapterTests', function () { ).to.equal(true); }); + it('discovery:no params', function () { + expect( + spec.isBidRequestValid({ + bidder: 'discovery', + params: {}, + }) + ).to.equal(true); + }); + it('discovery:validate_generated_params', function () { request = spec.buildRequests(bidRequestData.bids, bidRequestData); let req_data = JSON.parse(request.data); expect(req_data.imp).to.have.lengthOf(1); }); + + it('discovery:no_params', function () { + request = spec.buildRequests(bidRequestDataNoParams.bids, bidRequestData); + let req_data = JSON.parse(request.data); + expect(req_data.imp).to.have.lengthOf(0); + }); + describe('discovery: buildRequests', function() { describe('getPmgUID function', function() { let sandbox; From ebcfa378ceca00b9b015bea28175878f6bfd58e4 Mon Sep 17 00:00:00 2001 From: yubei01 Date: Fri, 19 Jan 2024 19:29:07 +0800 Subject: [PATCH 3/5] feat(spec): fix eslint --- test/spec/modules/discoveryBidAdapter_spec.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/spec/modules/discoveryBidAdapter_spec.js b/test/spec/modules/discoveryBidAdapter_spec.js index 82825d37f63..af170bbecc8 100644 --- a/test/spec/modules/discoveryBidAdapter_spec.js +++ b/test/spec/modules/discoveryBidAdapter_spec.js @@ -179,7 +179,6 @@ describe('discovery:BidAdapterTests', function () { expect(req_data.imp).to.have.lengthOf(1); }); - it('discovery:no_params', function () { request = spec.buildRequests(bidRequestDataNoParams.bids, bidRequestData); let req_data = JSON.parse(request.data); From e37811f78bafed6baa9ab854e7a490e95b440602 Mon Sep 17 00:00:00 2001 From: yubei01 Date: Fri, 19 Jan 2024 19:46:46 +0800 Subject: [PATCH 4/5] feat(spec): fix unit test --- test/spec/modules/discoveryBidAdapter_spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/spec/modules/discoveryBidAdapter_spec.js b/test/spec/modules/discoveryBidAdapter_spec.js index af170bbecc8..9ab207fc4b5 100644 --- a/test/spec/modules/discoveryBidAdapter_spec.js +++ b/test/spec/modules/discoveryBidAdapter_spec.js @@ -170,7 +170,7 @@ describe('discovery:BidAdapterTests', function () { bidder: 'discovery', params: {}, }) - ).to.equal(true); + ).to.be.undefined; }); it('discovery:validate_generated_params', function () { From 3d327f452f2f567ae490b34060cd28fd67a0b768 Mon Sep 17 00:00:00 2001 From: yubei01 Date: Fri, 19 Jan 2024 20:47:58 +0800 Subject: [PATCH 5/5] feat(spec): fix unit test --- test/spec/modules/discoveryBidAdapter_spec.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/test/spec/modules/discoveryBidAdapter_spec.js b/test/spec/modules/discoveryBidAdapter_spec.js index 9ab207fc4b5..65fbf33022f 100644 --- a/test/spec/modules/discoveryBidAdapter_spec.js +++ b/test/spec/modules/discoveryBidAdapter_spec.js @@ -164,13 +164,13 @@ describe('discovery:BidAdapterTests', function () { ).to.equal(true); }); - it('discovery:no params', function () { + it('isBidRequestValid:no_params', function () { expect( spec.isBidRequestValid({ bidder: 'discovery', params: {}, }) - ).to.be.undefined; + ).to.equal(true); }); it('discovery:validate_generated_params', function () { @@ -179,12 +179,6 @@ describe('discovery:BidAdapterTests', function () { expect(req_data.imp).to.have.lengthOf(1); }); - it('discovery:no_params', function () { - request = spec.buildRequests(bidRequestDataNoParams.bids, bidRequestData); - let req_data = JSON.parse(request.data); - expect(req_data.imp).to.have.lengthOf(0); - }); - describe('discovery: buildRequests', function() { describe('getPmgUID function', function() { let sandbox;