Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readpeak Bid Adapter : remove click url encoding #11120

Merged
merged 10 commits into from
Feb 20, 2024
Merged

Readpeak Bid Adapter : remove click url encoding #11120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cb76ecc
Add banner support to readpeak bid adapter
readpeaktuomo Mar 14, 2022
1ec5ef3
Merge branch 'prebid:master' into master
readpeaktuomo Jun 3, 2022
24bcbac
Add onBidWon callback to trigger burl
readpeaktuomo Jun 3, 2022
72e1d27
Remove .only from test
readpeaktuomo Jun 3, 2022
dd8ae70
Merge branch 'master' into master
readpeaktuomo Jun 13, 2022
ff89ca4
Fix merge
readpeaktuomo Jun 13, 2022
e204691
Merge branch 'prebid:master' into master
readpeaktuomo Jun 22, 2022
50197f1
Revert package-lock.json version update
readpeaktuomo Jun 22, 2022
4c1a228
Merge branch 'master' of github.com:readpeak/Prebid.js
readpeaktuomo Feb 20, 2024
c891596
Remove encoding of click target URL
readpeaktuomo Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/readpeakBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ function nativeResponse(imp, bid) {
keys.cta = asset.data && asset.id === 5 ? asset.data.value : keys.cta;
});
if (nativeAd.link) {
keys.clickUrl = encodeURIComponent(nativeAd.link.url);
keys.clickUrl = nativeAd.link.url;
}
const trackers = nativeAd.imptrackers || [];
trackers.unshift(replaceAuctionPrice(bid.burl, bid.price));
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/readpeakBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ describe('ReadPeakAdapter', function() {
height: 500
});
expect(bidResponse.native.clickUrl).to.equal(
'http%3A%2F%2Furl.to%2Ftarget'
'http://url.to/target'
);
expect(bidResponse.native.impressionTrackers).to.contain(
'http://url.to/pixeltracker'
Expand Down