From 67093b4070d051e597222a9e2679a67a298e7cce Mon Sep 17 00:00:00 2001 From: rcheptanariu <35690143+rcheptanariu@users.noreply.github.com> Date: Mon, 13 May 2024 10:47:04 +0300 Subject: [PATCH 1/5] InvibesBidAdapter - added cookie and referer read --- modules/invibesBidAdapter.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/modules/invibesBidAdapter.js b/modules/invibesBidAdapter.js index 2c37c0edad9..95c5744f127 100644 --- a/modules/invibesBidAdapter.js +++ b/modules/invibesBidAdapter.js @@ -14,7 +14,7 @@ const CONSTANTS = { SYNC_ENDPOINT: 'https://k.r66net.com/GetUserSync', TIME_TO_LIVE: 300, DEFAULT_CURRENCY: 'EUR', - PREBID_VERSION: 11, + PREBID_VERSION: 12, METHOD: 'GET', INVIBES_VENDOR_ID: 436, USERID_PROVIDERS: ['pubcid', 'pubProvidedId', 'uid2', 'zeotapIdPlus', 'id5id'], @@ -40,7 +40,7 @@ export const spec = { buildRequests: buildRequest, /** * @param {*} responseObj - * @param {requestParams} bidRequests + * @param {*} requestParams * @return {Bid[]} An array of bids which */ interpretResponse: function (responseObj, requestParams) { @@ -131,7 +131,6 @@ function buildRequest(bidRequests, bidderRequest) { window.invibes.placementIds.push(bidRequest.params.placementId); - _placementIds.push(bidRequest.params.placementId); _placementIds.push(bidRequest.params.placementId); _adUnitCodes.push(bidRequest.adUnitCode); _domainId = _domainId || bidRequest.params.domainId; @@ -181,8 +180,14 @@ function buildRequest(bidRequests, bidderRequest) { preventPageViewEvent: preventPageViewEvent, isPlacementRefresh: isPlacementRefresh, isInfiniteScrollPage: isInfiniteScrollPage, + pageReferrer: bidderRequest.refererInfo.ref.substring(0, 300) }; + let hid = invibes.getCookie('handIid'); + if (hid) { + data.handIid = hid; + } + let lid = readFromLocalStorage('ivbsdid'); if (!lid) { let str = invibes.getCookie('ivbsdid'); From 17c1827dcc283b118a32513e2720e4c87a2c559b Mon Sep 17 00:00:00 2001 From: rcheptanariu <35690143+rcheptanariu@users.noreply.github.com> Date: Mon, 13 May 2024 10:49:11 +0300 Subject: [PATCH 2/5] InvibesBidAdapter - unit tests --- test/spec/modules/invibesBidAdapter_spec.js | 44 +++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/test/spec/modules/invibesBidAdapter_spec.js b/test/spec/modules/invibesBidAdapter_spec.js index 056255c7738..ba2d8f5255a 100644 --- a/test/spec/modules/invibesBidAdapter_spec.js +++ b/test/spec/modules/invibesBidAdapter_spec.js @@ -560,6 +560,50 @@ describe('invibesBidAdapter:', function () { expect(request.data.lId).to.exist; }); + it('does not send handIid when it doesnt exist in cookie', function () { + top.window.invibes.optIn = 1; + top.window.invibes.purposes = [true, false, false, false, false, false, false, false, false, false]; + global.document.cookie = ''; + let bidderRequest = { + gdprConsent: { + vendorData: { + vendorConsents: { + 436: true + } + } + }, + refererInfo: { + page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' + } + }; + SetBidderAccess(); + + let request = spec.buildRequests(bidRequests, bidderRequest); + expect(request.data.handIid).to.not.exist; + }); + + it('sends handIid when comes on cookie', function () { + top.window.invibes.optIn = 1; + top.window.invibes.purposes = [true, false, false, false, false, false, false, false, false, false]; + global.document.cookie = 'handIid=abcdefghijkk'; + let bidderRequest = { + gdprConsent: { + vendorData: { + vendorConsents: { + 436: true + } + } + }, + refererInfo: { + page: 'https://randomWeb.com?someFakePara=fakeValue&secondParam=secondValue' + } + }; + SetBidderAccess(); + + let request = spec.buildRequests(bidRequests, bidderRequest); + expect(request.data.handIid).to.equal('abcdefghijkk'); + }); + it('should send purpose 1', function () { let bidderRequest = { gdprConsent: { From 32e83285fd7dcfb1454fd8a32cbf24579f745b74 Mon Sep 17 00:00:00 2001 From: rcheptanariu <35690143+rcheptanariu@users.noreply.github.com> Date: Mon, 13 May 2024 11:55:40 +0300 Subject: [PATCH 3/5] InvibesBidAdapter - tab fix --- modules/invibesBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/invibesBidAdapter.js b/modules/invibesBidAdapter.js index 95c5744f127..e002d0da201 100644 --- a/modules/invibesBidAdapter.js +++ b/modules/invibesBidAdapter.js @@ -180,7 +180,7 @@ function buildRequest(bidRequests, bidderRequest) { preventPageViewEvent: preventPageViewEvent, isPlacementRefresh: isPlacementRefresh, isInfiniteScrollPage: isInfiniteScrollPage, - pageReferrer: bidderRequest.refererInfo.ref.substring(0, 300) + pageReferrer: bidderRequest.refererInfo.ref.substring(0, 300) }; let hid = invibes.getCookie('handIid'); From f7aaddf97214bdfc6a48e8fb3e92967ee4425ba8 Mon Sep 17 00:00:00 2001 From: rcheptanariu <35690143+rcheptanariu@users.noreply.github.com> Date: Mon, 13 May 2024 13:34:33 +0300 Subject: [PATCH 4/5] InvibesBidAdapter - null checks --- modules/invibesBidAdapter.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/invibesBidAdapter.js b/modules/invibesBidAdapter.js index e002d0da201..d8e4a478a29 100644 --- a/modules/invibesBidAdapter.js +++ b/modules/invibesBidAdapter.js @@ -179,10 +179,12 @@ function buildRequest(bidRequests, bidderRequest) { isLocalStorageEnabled: storage.hasLocalStorage(), preventPageViewEvent: preventPageViewEvent, isPlacementRefresh: isPlacementRefresh, - isInfiniteScrollPage: isInfiniteScrollPage, - pageReferrer: bidderRequest.refererInfo.ref.substring(0, 300) + isInfiniteScrollPage: isInfiniteScrollPage }; + if (bidderRequest.refererInfo && bidderRequest.refererInfo.ref) + data.pageReferrer = bidderRequest.refererInfo.ref.substring(0, 300); + let hid = invibes.getCookie('handIid'); if (hid) { data.handIid = hid; From 9fc938eb50a43ccbdc293650562d93a9b7318608 Mon Sep 17 00:00:00 2001 From: rcheptanariu <35690143+rcheptanariu@users.noreply.github.com> Date: Mon, 13 May 2024 13:41:56 +0300 Subject: [PATCH 5/5] InvibesBidAdapter - fix { after if --- modules/invibesBidAdapter.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/invibesBidAdapter.js b/modules/invibesBidAdapter.js index d8e4a478a29..7ba2b8225b0 100644 --- a/modules/invibesBidAdapter.js +++ b/modules/invibesBidAdapter.js @@ -182,8 +182,9 @@ function buildRequest(bidRequests, bidderRequest) { isInfiniteScrollPage: isInfiniteScrollPage }; - if (bidderRequest.refererInfo && bidderRequest.refererInfo.ref) + if (bidderRequest.refererInfo && bidderRequest.refererInfo.ref) { data.pageReferrer = bidderRequest.refererInfo.ref.substring(0, 300); + } let hid = invibes.getCookie('handIid'); if (hid) {