Adagio Bid Adapter|Analytics Adapter|RTD Module: enforce enable tids

[Abyfall]

Type of change

• Updated bidder adapter
• Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

To ensure compatibility with our backend while staying compliant with the behavior introduced in #9781 we for some time generated our own specific auction id.

We will now rely on source.tid, thus requiring publishers to set enableTIDs to true.
The analyticsAdapter won't start if this option is not set to true

Other information

Reflecting changes in documentation prebid/prebid.github.io#5485

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/adagioBidAdapter.js has 9 duplicated lines with modules/insticatorBidAdapter.js
• modules/adagioBidAdapter.js has 15 duplicated lines with modules/insticatorBidAdapter.js
• modules/adagioBidAdapter.js has 18 duplicated lines with modules/mediakeysBidAdapter.js
• modules/adagioBidAdapter.js has 18 duplicated lines with modules/mediakeysBidAdapter.js
• modules/adagioBidAdapter.js has 25 duplicated lines with modules/mediakeysBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[github-actions]

Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):

• modules/adagioBidAdapter.js (+1 error)
• test/spec/modules/adagioRtdProvider_spec.js (+1 error)

[patmmccann]

You're not able to require publishers to set this, it's up to them

[Abyfall]

You're not able to require publishers to set this, it's up to them

Hi @patmmccann thanks for the feedback, this requirement is for analytics only. If enableTIDs = false it is not possible to join a "bid" with an analytics beacon because the bid won't have the auction_id, knowing that we prefer to "stop" the analytics module and avoid to send useless requests through the network. Is something wrong with that?

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/adagioBidAdapter.js has 9 duplicated lines with modules/insticatorBidAdapter.js
• modules/adagioBidAdapter.js has 15 duplicated lines with modules/insticatorBidAdapter.js
• modules/adagioBidAdapter.js has 18 duplicated lines with modules/mediakeysBidAdapter.js
• modules/adagioBidAdapter.js has 18 duplicated lines with modules/mediakeysBidAdapter.js
• modules/adagioBidAdapter.js has 25 duplicated lines with modules/mediakeysBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[patmmccann]

If enableTIDs = false it is not possible to join a "bid" with an analytics beacon because the bid won't have the auction_id,

Fairly sure bidderRequestId is in both objects, you guys are just not geting it in your adapter

Prebid.js/modules/adagioBidAdapter.js

Line 579 in 5d2fc68

const aucId = deepAccess(bidderRequest, 'ortb2.site.ext.data.adg_rtd.uid') || generateUUID()

here is how you should get it to give yourself a join key

Prebid.js/modules/oguryBidAdapter.js

Line 83 in 5d2fc68

id: bidderRequest.bidderRequestId,

[patmmccann]

Please also continue to make duplication progress, for example this can be imported from adagioUtils

Prebid.js/modules/insticatorBidAdapter.js

Line 274 in fb8d3ed

function _getGppConsent(bidderRequest) {

[Abyfall]

Hello @patmmccann following discussion on Slack I'm closing this PR. I will work no a new one and propose it. Thanks for your hindsights.